-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get column names from BED tabix files and other utils for external jbrowse-plugin-gwas support #1630
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1630 +/- ##
==========================================
+ Coverage 58.90% 58.92% +0.01%
==========================================
Files 446 446
Lines 20467 20493 +26
Branches 4824 4834 +10
==========================================
+ Hits 12057 12076 +19
- Misses 8112 8119 +7
Partials 298 298
Continue to review full report at Codecov.
|
There are some potential add ons to this that could include
|
Random observation: the manhattan plot on the my.locuszoom.org page is rendered with SVG using binned data, so each X coordinate is a line and a circle at the top instead of millions of circles. Apparently, it's also server side rendered, so you don't see any accessing the data file and only a small amount of rendered svg is downloaded over the wire to view that plot. It's still relatively slow to view that same track whole genome in this branch but there are probably some optimizations, and it is also possible to zoom in on jbrowse 2 which is important... |
8020d50
to
67e15f0
Compare
Rebased onto #1640 |
fed1304
to
40126ed
Compare
This PR sort of has a couple options to go forward
|
You can do this with |
thanks, that is quite interesting I found that if I tried to add a proper @jbrowse/plugin-wiggle to my devdeps I got some very weird errors even trying to run yarn
I may have to forego the typescripting on @jbrowse/plugin-wiggle and not have it in devdeps since that would be all that gains me |
I'll just modify this PR to erase core plugins/gwas from history |
b1f6911
to
059194b
Compare
I get that error when doing a top-level import of |
awesome thanks for checking that out |
Alright, I ripped the gwas plugin out into an external plugin, thanks very much @garrettjstevens for the tips If this remaining PR is merged then it would provide features that support to that plugin namely
|
Tested and the plugin does work if using this branch |
This adds a "linear manhattan plot display"
Also makes it so that stats are available on the base adapter, so that means that all the different adapters types that use some basic stats (which includes, SNPCoverageAdapter, BigWigAdapter, GCCoverageAdapter (#1624), and now BEDTabix for manhattan plot) all don't have to individually implement stats
This is similar to jbrowse 1 where the base seqfeature store has a local stats operation
Then it also adds ability for BedTabixAdapter to choose it's "score column" and read column names from the header of the bedtabix file if available
This allows us to choose the column named "neg_log_pvalue" in the summary_stats.txt.gz file as the score that is plotted with the manhattan plot from a tabix file prepared from summary_stats.txt.gz from here https://my.locuszoom.org/gwas/236887/
Can display whole-genome-wide results and local results