Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to filter for read name to the alignments filter dialog #1604

Merged
merged 4 commits into from
Jan 8, 2021

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Jan 6, 2021

This adds a filter for read name, so that you can enter a specific readname and get the output. Somewhat handily, you can then un-set the filter and the read remains focused which can be nice

localhost_3000__config=test_data%2Fconfig json session=local-sG8ExZNo9

@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

Merging #1604 (57f8662) into master (f94826e) will decrease coverage by 0.01%.
The diff coverage is 22.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1604      +/-   ##
==========================================
- Coverage   59.15%   59.13%   -0.02%     
==========================================
  Files         439      439              
  Lines       20030    20039       +9     
  Branches     4705     4708       +3     
==========================================
+ Hits        11849    11851       +2     
- Misses       7884     7891       +7     
  Partials      297      297              
Impacted Files Coverage Δ
...src/LinearPileupDisplay/components/FilterByTag.tsx 5.00% <0.00%> (-0.41%) ⬇️
...lugins/alignments/src/LinearPileupDisplay/model.ts 75.62% <33.33%> (-0.81%) ⬇️
...ments/src/LinearSNPCoverageDisplay/models/model.ts 84.21% <33.33%> (-4.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f94826e...c9cc4f2. Read the comment docs.

@cmdcolin
Copy link
Collaborator Author

cmdcolin commented Jan 6, 2021

cc @rbuels has been something we've talked about before :)

@cmdcolin cmdcolin force-pushed the filter_for_read_name branch from 1b8bc87 to 51a38d7 Compare January 6, 2021 19:56
@garrettjstevens garrettjstevens added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jan 6, 2021
@rbuels rbuels added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Jan 7, 2021
@cmdcolin cmdcolin force-pushed the filter_for_read_name branch from d168710 to 57f8662 Compare January 8, 2021 00:09
@cmdcolin cmdcolin force-pushed the filter_for_read_name branch from 57f8662 to c9cc4f2 Compare January 8, 2021 02:21
@cmdcolin cmdcolin merged commit c17de3b into master Jan 8, 2021
@cmdcolin cmdcolin deleted the filter_for_read_name branch January 8, 2021 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants