Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace 'show all regions' with 'show all regions in assembly' #1599

Merged
merged 4 commits into from
Jan 6, 2021

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Jan 6, 2021

This is a break out from #1531

This adds a new behavior where we can "Show all regions in assembly" and also changes a behavior so that maxBpPerPx is conditional on totalBp/(self.width*0.9) rather than totalBp/1000

That means on a wide monitor, the behavior for "Show all regions in assembly" would use more of those horizontal pixels than just choosing to squish everything down to 1000

@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

Merging #1599 (8a42457) into master (6a3b345) will increase coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1599   +/-   ##
=======================================
  Coverage   59.18%   59.18%           
=======================================
  Files         438      438           
  Lines       19907    19924   +17     
  Branches     4675     4679    +4     
=======================================
+ Hits        11781    11792   +11     
- Misses       7832     7838    +6     
  Partials      294      294           
Impacted Files Coverage Δ
...s/linear-genome-view/src/LinearGenomeView/index.ts 80.37% <66.66%> (-0.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a3b345...51624e3. Read the comment docs.

@cmdcolin
Copy link
Collaborator Author

cmdcolin commented Jan 6, 2021

I could also alternatively keep the concept of the divide by 1000, and then only conditionally in showAllRegionsForAssembly zoom out using self.width but I might prefer how it is here

@cmdcolin cmdcolin merged commit 17175e3 into master Jan 6, 2021
@cmdcolin cmdcolin deleted the show_all_regions_in_assembly branch January 6, 2021 21:42
@garrettjstevens garrettjstevens added needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants