-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Get sequence" action to LGV rubber-band #1588
Conversation
…nto 898_get_sequence
…nto 898_get_sequence
…nce for mult displayed regions
…nto 898_get_sequence
Codecov Report
@@ Coverage Diff @@
## master #1588 +/- ##
==========================================
+ Coverage 58.98% 59.12% +0.13%
==========================================
Files 439 441 +2
Lines 20108 20250 +142
Branches 4609 4654 +45
==========================================
+ Hits 11861 11973 +112
- Misses 7951 7978 +27
- Partials 296 299 +3
Continue to review full report at Codecov.
|
Untitled.2.mov |
@scottcain look at that video ;-) |
🤩 Looks awesome! How tricky would it be to also support getting the locstring instead of sequence? Would be useful for certain use cases I think. |
I would maybe suggest that the "Get sequence" by default grabs FASTA, and that each displayed region is a section of FASTA with the locstring in the header so it might look like
|
This is a bit of a weird idea but I thought maybe we could simplify the current implementation of getSelectedRegions using dynamicBlocks, since dynamicBlocks basically gives us the calculated "visible regions"...so I thought maybe we could use it to get selected regions too I created a "simulated" Base1DView from a snapshot of the LinearGenomeView, and then simulate zoomToDisplayedRegions on it, and then get simulatedView.dynamicBlocks https://github.com/GMOD/jbrowse-components/tree/898_get_sequence_mod Random other thing but the branch also uses a monospace font for the textarea |
went ahead and merged ^_^ if there are any follow ups maybe we can do new issues but afaict it works good |
Jbrowse2_get_sequence.mov |
Issue 898
Get the reference sequence for the rubber-banded area.
Created get sequence dialog that opens when a section in the LGV rubber-band is selected.TODO:
Pops up a modal dialog that has:button to copy to clipboardfilename text field (with good default name)Regions selected contains out of bound coordCan select all regionsCan select entire regionCan select in between regionsCan select multiple displayed RegionsError Handling
Disabled if there is no sequence adapter for the assembly in questionDisabled (grayed out) if more than 500MBcopy to clipboard (turned off if no clipboard support)textarea with the exported sequence in FASTA format, textarea is not displayed if more than 100KB of sequenceTests
tests for dialog opening/closingtests get selectedRegionstest format and size of file