-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add location string to tooltip for wiggle and SNPCoverage tracks #1576
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1576 +/- ##
==========================================
- Coverage 59.51% 59.48% -0.03%
==========================================
Files 435 435
Lines 19564 19584 +20
Branches 4567 4573 +6
==========================================
+ Hits 11643 11650 +7
- Misses 7627 7640 +13
Partials 294 294
Continue to review full report at Codecov.
|
@garrettjstevens added a change for that, also corrects it to use feature.get('start')+1 for the displayed loc |
dc93f03
to
eeb2283
Compare
I made an additional proposal to the feature detail dialogs that it makes model.featureData=undefined by default rather than model.featureData={} This uses types.frozen() instead of types.frozen({}) in the model definition If this is not the case, then the base feature details can receive undefined entries for start,end,etc. and then end.toLocaleString is a crash, etc. |
Just because there is some precedent for these things possibly being an empty object, to avoid a crash, I check for empty object now |
Kind of simple but something that I think can help readability