Remove the TextDecoder/TextEncoder polyfill #1555
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1553 by removing the TextDecoder polyfill we were using
It has different behavior to what exists on the proper https://developer.mozilla.org/en-US/docs/Web/API/TextDecoder
Hard exactly to tell why but the TextDecoder object we were receiving was not a proper instance of a TextDecoder
Possibly related to how this module allows multiple different ways of importing the module
https://github.com/anonyco/FastestSmallestTextEncoderDecoder
Note that caniuse says that all our browsers we target are ok without this https://caniuse.com/textencoder