Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix analytics crashing when using plugins #1547

Merged
merged 3 commits into from
Dec 11, 2020
Merged

Conversation

cmdcolin
Copy link
Collaborator

This is a quick PR just to make sure that plugins can work. Currently the analytics try to snapshot a non-mst model for this

@cmdcolin
Copy link
Collaborator Author

@garrettjstevens Just figured i'd make a quick PR to streamline this in

@codecov
Copy link

codecov bot commented Dec 11, 2020

Codecov Report

Merging #1547 (2239dc0) into master (2fb836d) will increase coverage by 0.16%.
The diff coverage is 89.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1547      +/-   ##
==========================================
+ Coverage   59.48%   59.65%   +0.16%     
==========================================
  Files         435      435              
  Lines       19538    19527      -11     
  Branches     4552     4550       -2     
==========================================
+ Hits        11622    11648      +26     
+ Misses       7621     7586      -35     
+ Partials      295      293       -2     
Impacted Files Coverage Δ
...me-view/src/LinearGenomeView/components/Header.tsx 90.00% <ø> (+11.15%) ⬆️
...iew/src/LinearGenomeView/components/ImportForm.tsx 75.86% <50.00%> (-5.62%) ⬇️
...inearGenomeView/components/RefNameAutocomplete.tsx 91.37% <91.11%> (+51.37%) ⬆️
packages/core/util/analytics.ts 86.48% <100.00%> (+10.87%) ⬆️
...s/linear-genome-view/src/LinearGenomeView/index.ts 84.10% <0.00%> (+0.38%) ⬆️
...ns/linear-genome-view/src/LinearGenomeView/util.ts 97.77% <0.00%> (+4.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6a54eb...2239dc0. Read the comment docs.

@cmdcolin cmdcolin merged commit d458553 into master Dec 11, 2020
@cmdcolin cmdcolin added the bug Something isn't working label Dec 11, 2020
@cmdcolin cmdcolin deleted the fix_plugin_imports branch December 11, 2020 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant