Fix memory leak when side scrolling LGV blocks #1540
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was possibly a memory leak from side scrolling blocks. I saw memory increasing pretty high from sidescrolling lgv
I looked and this code was not called for example
We could adjust the use of the isHydrated variable but also it seems this fix on this branch is a simpler approach: always unmount because it is a do nothing if not mounted https://reactjs.org/docs/react-dom.html#unmountcomponentatnode