Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display subfeatures in feature details widget #1529

Merged
merged 6 commits into from
Dec 8, 2020

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Dec 7, 2020

Alternative to #1317

@cmdcolin
Copy link
Collaborator Author

cmdcolin commented Dec 7, 2020

The aims of this include

  1. Include a bit of refactoring that was done in mygene.info adapter and data table in the feature details widgets #1503
  2. Render subfeature details from Add subfeature details to the feature details widget #1317
  3. Avoid the issue of Add subfeature details to the feature details widget #1317 where all subfeatures are in a list, and instead allow nested subfeatures
  4. Always render one level of subfeatures, and make the rest in a defaultExpanded=false accordion

const feat = JSON.parse(JSON.stringify(model.featureData))
return (
<Paper data-testid="alignment-side-drawer">
<BaseFeatureDetails
<BaseFeatureDetails {...props} />
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not seeing the performance hit from viewing a long read that was seen previously, so this was removed

@cmdcolin
Copy link
Collaborator Author

cmdcolin commented Dec 7, 2020

Screenshot

localhost_3000__config=test_data%2Fvolvox%2Fconfig json session=local-6iQC0ihJW

@codecov
Copy link

codecov bot commented Dec 7, 2020

Codecov Report

Merging #1529 (d0738a3) into master (221c8ba) will decrease coverage by 0.01%.
The diff coverage is 71.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1529      +/-   ##
==========================================
- Coverage   59.52%   59.50%   -0.02%     
==========================================
  Files         435      435              
  Lines       19501    19526      +25     
  Branches     4540     4551      +11     
==========================================
+ Hits        11607    11619      +12     
- Misses       7599     7611      +12     
- Partials      295      296       +1     
Impacted Files Coverage Δ
...kages/core/BaseFeatureWidget/BaseFeatureDetail.tsx 82.75% <71.69%> (-14.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 993e071...d0738a3. Read the comment docs.

@cmdcolin cmdcolin changed the title Allow subfeatures Display subfeatures in feature details widget Dec 7, 2020
@cmdcolin cmdcolin force-pushed the render_subfeature_details branch 2 times, most recently from 61f6391 to 9de7f7b Compare December 7, 2020 23:10
@cmdcolin cmdcolin force-pushed the render_subfeature_details branch from 9de7f7b to add298e Compare December 7, 2020 23:14
@cmdcolin cmdcolin force-pushed the render_subfeature_details branch from 0af7c45 to d0738a3 Compare December 7, 2020 23:38
@cmdcolin cmdcolin force-pushed the render_subfeature_details branch from 43882f7 to e7517d2 Compare December 8, 2020 00:13
@cmdcolin cmdcolin marked this pull request as ready for review December 8, 2020 00:23
@cmdcolin cmdcolin merged commit 35bedf4 into master Dec 8, 2020
@cmdcolin cmdcolin deleted the render_subfeature_details branch December 8, 2020 01:12
@cmdcolin cmdcolin added the enhancement New feature or request label Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant