-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve assembly loading time by moving to main thread #1438
Conversation
Note that the goals of this PR are knock-on effects from wanting to add a test for the location-search box, which means the assembly has to be initialized Therefore we
If assembly loading is not done in the main thread, the loading time for a basic LGV is much worse because it has to wait on the webworker JS to download, parse, run, etc before anything is displayed |
c602c33
to
4703901
Compare
The tests on this branch for me pass locally but do not pass on travis https://travis-ci.com/github/GMOD/jbrowse-components/builds/200457135 |
Codecov Report
@@ Coverage Diff @@
## master #1438 +/- ##
==========================================
- Coverage 60.00% 59.81% -0.19%
==========================================
Files 426 425 -1
Lines 19395 19004 -391
Branches 4581 4448 -133
==========================================
- Hits 11638 11368 -270
+ Misses 7465 7346 -119
+ Partials 292 290 -2
Continue to review full report at Codecov.
|
This is now tests passing |
if CoreGetRegions and CoreGetRefNameAliases are no longer used, let's add deleting them to this PR |
4fff527
to
79c3d37
Compare
I was somewhat comfortable with this However, running git checkout origin/master test_data....This reverts the test_data/volvox/config.json back to volvox.2bit and then the tests fail...the volvox.2bit fails while the indexedfasta succeeds. This is somewhat concerning and may be worth looking into |
Traced the aforementioned loading failure of volvox.2bit to usage of jest.useFakeTimers being enabled (and then deep in http-range-fetcher depending on usage of a setTimeout). I disabled usage of useFakeTimers for now to fix |
92103c8
to
c2ebab2
Compare
This is an alternative to #1406 that performs assembly loading on the main thread
This improves loading time, and makes it so the assembly is waited on before the app is called initialized