Simpler crypto #1374
Merged
Simpler crypto #1374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #1356 and also #1326 I made this PR to have a simpler crypto implementation. The bundle size improvements are not updated yet AFAIK but I think this result is a good code change anyways
I think the results are easier to read in the code though and it doesn't use a fake key, just a random password
Also updates the lambda to make the session id shorter and the full hash is not generally needed, just a small amount of randomness. This change is already live
Note that this change would make currently shared sessions obsolete so deploying to yet a new base URI. I do this by removing the beta prefix