Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix windows desktop build certificate causing failed upgrades #4568

Closed
cmdcolin opened this issue Sep 17, 2024 · 4 comments
Closed

Fix windows desktop build certificate causing failed upgrades #4568

cmdcolin opened this issue Sep 17, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@cmdcolin
Copy link
Collaborator

Was noticed that upgrades on windows fail, and that it is probably being signed with an out of date certificate

Need to review how to sign it properly. It might involve creating a new certificate because i'm not sure if we have the original "private key"

May also want to fill out form with microsoft attesting ownership over the app as e.g. edge browser produces warnings for people trying to install it
@cmdcolin cmdcolin added the enhancement New feature or request label Sep 17, 2024
@cmdcolin
Copy link
Collaborator Author

cmdcolin commented Sep 17, 2024 •
edited
Loading

currently fails to upgrade with a message like this

@cmdcolin
Copy link
Collaborator Author

Untitled

@cmdcolin
Copy link
Collaborator Author

fixed in v2.15.3

@cmdcolin
Copy link
Collaborator Author

see #4571

there is also a private google doc on the process https://docs.google.com/document/d/1Rwok080ri4OGDkyqLGFQqqeXGOkBDo_GxqVuNq5IDAs/edit?usp=drive_link

@cmdcolin cmdcolin changed the title Fix windows desktop build certificate Fix windows desktop build certificate causing failed upgrades Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cmdcolin