Fix code signing on the windows for jbrowse desktop #4571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmdcolin
force-pushed
the
ssl_signer
branch
from
6ce27c5 to
078303e
Compare
cmdcolin
force-pushed
the
ssl_signer
branch
from
078303e to
370cf2d
Compare
…ha1, but this is deprecated by electron https://www.electronjs.org/blog/windows-7-to-8-1-deprecation-notice)
|
note that if we sign a ton of stuff, it might incur a cost but i think we get 20 free ones per month https://www.ssl.com/guide/esigner-pricing-for-code-signing/ each version release i think runs maybe 4 or so signings (multiple exe files are signed in the installer distribution) |
|
"free" meaning...paid with our subscription... |
|
I created a google drive doc with some screenshots documenting my experience with this, it is private to our shared drive https://docs.google.com/document/d/1Rwok080ri4OGDkyqLGFQqqeXGOkBDo_GxqVuNq5IDAs/edit?usp=sharing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is an attempt to get our SSL code signing back into action for our windows app
it had been apparently broken for awhile i believe our certificate was expired since mid-2023, and even attempting to fix it would not work because at that same time in mid-2023 they disabled the method we were using (downloading the p12/pfx file to the WIN_CSC_LINK env variable)
this PR's new solution closely follows electron-userland/electron-builder#6158