More fixes to not use getSnapshot for assembly regions

GMOD · Jun 21, 2021 · e20b7fe · e20b7fe
1 parent f3deaba
commit e20b7fe
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 5 deletions.
diff --git a/packages/core/assemblyManager/assembly.ts b/packages/core/assemblyManager/assembly.ts
@@ -145,7 +145,15 @@ export default function assemblyFactory(
   return types
     .model({
       configuration: types.safeReference(assemblyConfigType),
-      regions: types.frozen(),
+      regions: types.frozen<
+        | {
+            start: number
+            end: number
+            refName: string
+            assemblyName: string
+          }[]
+        | undefined
+      >(),
       refNameAliases: types.maybe(types.map(types.string)),
     })
     .views(self => ({

diff --git a/plugins/linear-genome-view/src/LinearGenomeView/components/Header.tsx b/plugins/linear-genome-view/src/LinearGenomeView/components/Header.tsx
@@ -6,7 +6,7 @@ import { fade } from '@material-ui/core/styles/colorManipulator'
 import FormGroup from '@material-ui/core/FormGroup'
 import Typography from '@material-ui/core/Typography'
 import { observer } from 'mobx-react'
-import { Instance, getEnv, getSnapshot } from 'mobx-state-tree'
+import { Instance, getEnv } from 'mobx-state-tree'
 import React from 'react'
 
 import { TrackSelector as TrackSelectorIcon } from '@jbrowse/core/ui/Icons'
@@ -129,7 +129,7 @@ const LinearGenomeViewHeader = observer(({ model }: { model: LGV }) => {
         region => newRegionValue === region.refName,
       )
       if (newRegion) {
-        model.setDisplayedRegions([getSnapshot(newRegion)])
+        model.setDisplayedRegions([newRegion])
         // we use showAllRegions after setDisplayedRegions to make the entire
         // region visible, xref #1703
         model.showAllRegions()

diff --git a/plugins/linear-genome-view/src/LinearGenomeView/components/SearchResultsDialog.tsx b/plugins/linear-genome-view/src/LinearGenomeView/components/SearchResultsDialog.tsx
@@ -76,7 +76,7 @@ export default function SearchResultsDialog({
         region => location === region.refName,
       )
       if (newRegion) {
-        model.setDisplayedRegions([getSnapshot(newRegion)])
+        model.setDisplayedRegions([newRegion])
         // we use showAllRegions after setDisplayedRegions to make the entire
         // region visible, xref #1703
         model.showAllRegions()

diff --git a/plugins/linear-genome-view/src/LinearGenomeView/index.tsx b/plugins/linear-genome-view/src/LinearGenomeView/index.tsx
@@ -766,7 +766,7 @@ export function stateModelFactory(pluginManager: PluginManager) {
             region => region.refName === canonicalRefName,
           )
           if (newDisplayedRegion) {
-            this.setDisplayedRegions([getSnapshot(newDisplayedRegion)])
+            this.setDisplayedRegions([newDisplayedRegion])
           } else {
             throw new Error(
               `Could not find refName ${parsedLocString.refName} in ${assembly.name}`,