Restore eslint rule for @typescript-eslint/no-unused-vars (#2078)

* Remove unused vars

* Allow unused with "_" prefix

* Disable eslint plugin in webpack build

Co-authored-by: Garrett Stevens <[email protected]>

.eslintrc.base.json

@@ -26,7 +26,14 @@
     "@typescript-eslint/explicit-function-return-type": "off",
     "@typescript-eslint/explicit-module-boundary-types": "off",
     "@typescript-eslint/no-empty-function": "off",
-    "@typescript-eslint/no-unused-vars": "off",
+    "@typescript-eslint/no-unused-vars": [
+      "warn",
+      {
+        "ignoreRestSiblings": true,
+        "argsIgnorePattern": "^_",
+        "varsIgnorePattern": "^_"
+      }
+    ],
     "@typescript-eslint/no-use-before-define": "off",
     "@typescript-eslint/no-var-requires": "off",
     "@typescript-eslint/no-redeclare": "off",

packages/core/TextSearch/BaseResults.test.ts

@@ -1,8 +1,4 @@
-import BaseResult, {
-  LocStringResult,
-  RefSequenceResult,
-  BaseResultArgs,
-} from './BaseResults'
+import BaseResult, { LocStringResult, RefSequenceResult } from './BaseResults'
 
 test('create BaseResult', () => {
   const baseResult = new BaseResult({

packages/core/TextSearch/TextSearchManager.ts

@@ -6,7 +6,6 @@ import PluginManager from '../PluginManager'
 import QuickLRU from '../util/QuickLRU'
 import { SearchType, BaseTextSearchAdapter } from '../data_adapters/BaseAdapter'
 import { readConfObject } from '../configuration'
-import TextSearchAdapterType from '../pluggableElementTypes/TextSearchAdapterType'
 
 export interface BaseArgs {
   searchType: SearchType

packages/core/assemblyManager/assembly.ts

@@ -1,5 +1,5 @@
 import jsonStableStringify from 'json-stable-stringify'
-import { cast, getParent, IAnyType, types, Instance } from 'mobx-state-tree'
+import { getParent, IAnyType, types, Instance } from 'mobx-state-tree'
 import AbortablePromiseCache from 'abortable-promise-cache'
 import { readConfObject } from '../configuration'
 import {
@@ -8,7 +8,6 @@ import {
 } from '../data_adapters/BaseAdapter'
 import PluginManager from '../PluginManager'
 import { Region } from '../util/types'
-import { Region as MSTRegion } from '../util/types/mst'
 import { makeAbortableReaction, when } from '../util'
 import QuickLRU from '../util/QuickLRU'
 

packages/core/rpc/RpcManager.ts

@@ -6,7 +6,6 @@ import WebWorkerRpcDriver from './WebWorkerRpcDriver'
 import MainThreadRpcDriver from './MainThreadRpcDriver'
 import ElectronRpcDriver from './ElectronRpcDriver'
 import { AnyConfigurationModel } from '../configuration/configurationSchema'
-import { PluginDefinition } from '../PluginLoader'
 
 type DriverClass = WebWorkerRpcDriver | MainThreadRpcDriver | ElectronRpcDriver
 type BackendConfigurations = {

packages/core/ui/FileSelector.tsx

@@ -11,10 +11,6 @@ import { ToggleButtonGroup, ToggleButton } from '@material-ui/lab'
 import { observer } from 'mobx-react'
 import { isElectron } from '../util'
 import {
-  PreLocalPathLocation,
-  PreUriLocation,
-  PreBlobLocation,
-  PreFileLocation,
   LocalPathLocation,
   UriLocation,
   FileLocation,

packages/core/util/types/index.ts

@@ -1,7 +1,6 @@
 import {
   isStateTreeNode,
   Instance,
-  SnapshotOut,
   SnapshotIn,
   IAnyStateTreeNode,
 } from 'mobx-state-tree'

plugins/alignments/src/LinearSNPCoverageDisplay/models/model.ts

@@ -9,7 +9,7 @@ import {
 import PluginManager from '@jbrowse/core/PluginManager'
 import SerializableFilterChain from '@jbrowse/core/pluggableElementTypes/renderers/util/serializableFilterChain'
 import { getParentRenderProps } from '@jbrowse/core/util/tracks'
-import { getSession, getContainingView } from '@jbrowse/core/util'
+import { getContainingView } from '@jbrowse/core/util'
 import Tooltip from '../components/Tooltip'
 import { getUniqueModificationValues } from '../../shared'
 import { LinearGenomeViewModel } from '@jbrowse/plugin-linear-genome-view'

plugins/data-management/src/PluginStoreWidget/components/InstalledPluginsList.tsx

@@ -5,8 +5,6 @@ import List from '@material-ui/core/List'
 import Typography from '@material-ui/core/Typography'
 
 import type PluginManager from '@jbrowse/core/PluginManager'
-import type { BasePlugin } from '@jbrowse/core/util/types'
-
 import { PluginStoreModel } from '../model'
 import InstalledPlugin from './InstalledPlugin'
 

plugins/dotplot-view/src/PAFAdapter/PAFAdapter.ts

@@ -60,12 +60,12 @@ export default class PAFAdapter extends BaseFeatureDataAdapter {
       if (line.length) {
         const [
           chr1,
-          queryRefSeqLen,
+          ,
           start1,
           end1,
           strand,
           chr2,
-          targetRefSeqLen,
+          ,
           start2,
           end2,
           numMatches,

plugins/legacy-jbrowse/src/JBrowse1Connection/jb1ToJb2.ts

@@ -8,7 +8,7 @@ import {
   UNKNOWN,
   UNSUPPORTED,
 } from '@jbrowse/core/util/tracks'
-import { JBLocation, Track, RefSeqs, RefSeq } from './types'
+import { Track, RefSeqs, RefSeq } from './types'
 
 interface Jb2Track {
   trackId: string

plugins/linear-comparative-view/src/index.tsx

@@ -239,11 +239,11 @@ function WindowSizeDlg(props: {
       const supplementaryAlignments = SA.split(';')
         .filter(aln => !!aln)
         .map((aln, index) => {
-          const [saRef, saStart, saStrand, saCigar] = aln.split(',')
+          const [saRef, saStart, , saCigar] = aln.split(',')
           const saLengthOnRef = getLengthOnRef(saCigar)
           const saLength = getLength(saCigar)
           const saLengthSansClipping = getLengthSansClipping(saCigar)
-          const saStrandNormalized = saStrand === '-' ? -1 : 1
+          // const saStrandNormalized = saStrand === '-' ? -1 : 1
           const saClipPos = getClip(saCigar, 1)
           const saRealStart = +saStart - 1
           return {

plugins/linear-genome-view/src/LinearGenomeView/components/ImportForm.tsx

@@ -1,12 +1,9 @@
 import React, { useState, useEffect } from 'react'
 import { observer } from 'mobx-react'
-import { getSnapshot, getEnv } from 'mobx-state-tree'
+import { getEnv } from 'mobx-state-tree'
 import { getSession } from '@jbrowse/core/util'
 import { Region } from '@jbrowse/core/util/types'
-import BaseResult, {
-  RefSequenceResult,
-  LocStringResult,
-} from '@jbrowse/core/TextSearch/BaseResults'
+import BaseResult from '@jbrowse/core/TextSearch/BaseResults'
 // material ui
 import { makeStyles } from '@material-ui/core/styles'
 import Button from '@material-ui/core/Button'

plugins/linear-genome-view/src/LinearGenomeView/components/LinearGenomeView.tsx

@@ -146,11 +146,9 @@ function ScaleBar({ model, fontSize }: { model: LGV; fontSize: number }) {
 function SVGRuler({
   model,
   fontSize,
-  rulerHeight,
   width,
 }: {
   model: LGV
-  rulerHeight: number
   fontSize: number
   width: number
 }) {
@@ -226,12 +224,7 @@ const SVGHeader = ({ model }: { model: LGV }) => {
         <ScaleBar model={model} fontSize={fontSize} />
       </g>
       <g transform={`translate(0 ${rulerHeight})`}>
-        <SVGRuler
-          model={model}
-          fontSize={fontSize}
-          rulerHeight={rulerHeight}
-          width={width}
-        />
+        <SVGRuler model={model} fontSize={fontSize} width={width} />
       </g>
     </g>
   )

plugins/linear-genome-view/src/LinearGenomeView/components/RefNameAutocomplete.tsx

@@ -87,7 +87,6 @@ function RefNameAutocomplete({
 }) {
   const classes = useStyles()
   const session = getSession(model)
-  const { pluginManager } = getEnv(session)
   const [open, setOpen] = useState(false)
   const [, setError] = useState<Error>()
   const [currentSearch, setCurrentSearch] = useState('')
@@ -133,8 +132,6 @@ function RefNameAutocomplete({
 
   options =
     options.length > 100 ? options.slice(0, 100).concat(limitOption) : options
-  // assembly and regions have loaded
-  const loaded = regions.length !== 0 && assemblyName
   useEffect(() => {
     let active = true
 

plugins/linear-genome-view/src/LinearGenomeView/components/SearchResultsDialog.tsx

@@ -1,10 +1,5 @@
 import React from 'react'
-import {
-  getSnapshot,
-  getEnv,
-  resolveIdentifier,
-  getRoot,
-} from 'mobx-state-tree'
+import { getEnv, resolveIdentifier, getRoot } from 'mobx-state-tree'
 import { getSession } from '@jbrowse/core/util'
 import {
   Button,

plugins/linear-genome-view/src/LinearGenomeView/index.test.ts

@@ -1,6 +1,5 @@
 import { ConfigurationSchema } from '@jbrowse/core/configuration'
 import DisplayType from '@jbrowse/core/pluggableElementTypes/DisplayType'
-import { Region } from '@jbrowse/core/util/types/mst'
 import {
   createBaseTrackConfig,
   createBaseTrackModel,

products/jbrowse-aws-lambda-functions/saved-sessions/jbrowse_analytics.js

@@ -62,7 +62,7 @@ function recordStats(event, context, done) {
 
 exports.handler = (event, context, callback) => {
   // console.log('Received event:', JSON.stringify(event, null, 2));
-  const done = (err, res) =>
+  const done = err =>
     callback(null, {
       statusCode: err ? '400' : '200',
       body: err

products/jbrowse-desktop/.env

@@ -0,0 +1 @@
+DISABLE_ESLINT_PLUGIN=true

products/jbrowse-react-linear-genome-view/src/createModel/createSessionModel.ts

@@ -350,6 +350,7 @@ export default function sessionModelFactory(pluginManager: PluginManager) {
 export type SessionStateModel = ReturnType<typeof sessionModelFactory>
 export type SessionModel = Instance<SessionStateModel>
 
+// eslint-disable-next-line @typescript-eslint/no-unused-vars
 function z(x: Instance<SessionStateModel>): AbstractSessionModel {
   // this function's sole purpose is to get typescript to check
   // that the session model implements all of AbstractSessionModel

products/jbrowse-react-linear-genome-view/src/deprecations.tsx

@@ -11,10 +11,10 @@ export function createJBrowseTheme(theme?: ThemeOptions) {
 }
 
 export function ThemeProvider({
-  theme,
+  _theme,
   children,
 }: {
-  theme: Theme
+  _theme: Theme
   children: ReactNode
 }) {
   console.warn(

products/jbrowse-web/.env

@@ -0,0 +1 @@
+DISABLE_ESLINT_PLUGIN=true

products/jbrowse-web/src/Loader.tsx

@@ -17,7 +17,6 @@ import {
 import { AnyConfigurationModel } from '@jbrowse/core/configuration/configurationSchema'
 import { types, addDisposer, Instance, SnapshotOut } from 'mobx-state-tree'
 import { autorun } from 'mobx'
-import { PluginConstructor } from '@jbrowse/core/Plugin'
 import { FatalErrorDialog } from '@jbrowse/core/ui'
 import 'fontsource-roboto'
 import 'requestidlecallback-polyfill'

products/jbrowse-web/src/rootModel.ts

@@ -184,7 +184,7 @@ export default function RootModel(
         addDisposer(
           self,
           autorun(() => {
-            for (const [_, val] of self.savedSessionsVolatile.entries()) {
+            for (const [, val] of self.savedSessionsVolatile.entries()) {
               try {
                 const key = self.localStorageId(val.name)
                 localStorage.setItem(key, JSON.stringify({ session: val }))

products/jbrowse-web/src/sessionModelFactory.test.js

@@ -23,6 +23,7 @@ describe('JBrowseWebSessionModel', () => {
       { name: 'testSession' },
       { pluginManager },
     )
+
     const { id, ...rest } = getSnapshot(session)
     expect(rest).toMatchSnapshot()
   })

products/jbrowse-web/src/sessionModelFactory.ts

@@ -716,6 +716,7 @@ export default function sessionModelFactory(
 export type SessionStateModel = ReturnType<typeof sessionModelFactory>
 export type SessionModel = Instance<SessionStateModel>
 
+// eslint-disable-next-line @typescript-eslint/no-unused-vars
 function z(x: Instance<SessionStateModel>): AbstractSessionModel {
   // this function's sole purpose is to get typescript to check
   // that the session model implements all of AbstractSessionModel