Skip to content

Commit

Permalink
Use github URL for screenshot
Browse files Browse the repository at this point in the history
  • Loading branch information
@elliothershberg
elliothershberg committed May 3, 2021
1 parent 4cd8883 commit 677ed32
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion website/release_announcement_drafts/v1.2.0.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ SVG export of track visualizations! This feature currently supports
the linear genome view, and will be extended to more views in future
releases.

![](./img/svg_screenshot.png)
![](https://raw.githubusercontent.com/cmdcolin/jb2export/master/img/1.png)

With the addition of this feature, it is now even easier to create
publication-ready screenshots of JBrowse views.
Expand Down
Binary file removed website/static/img/svg_screenshot.png
View file
Binary file not shown.

7 comments on commit 677ed32

@cmdcolin
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for this change? If this repo moves to GMOD/jb2export link will break

@garrettjstevens
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it will break: https://github.blog/2013-05-16-repository-redirects-are-here/

@cmdcolin
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is not clear from that link that raw.githubcontent urls will transfer from that link

@elliothershberg
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could maybe keep this in mind for a potential move?

@cmdcolin
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose so, just wasn't clear to me why this change was made though

@elliothershberg
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@garrettjstevens mentioned that the relative link wouldn't work once the blog post was created

@garrettjstevens
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'll work in the blog post, but not in the release announcement. Maybe we need a place to host images for these.

Please sign in to comment.