-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Api tweaks #1952
Api tweaks #1952
Conversation
Co-authored-by: Philip Top <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* merge documentation changes and update support for cmake 3.20 and boost 1.76 * Update docs/user-guide/advanced_topics/webserver.md Co-authored-by: Ryan Mast <[email protected]> * Automated formatting of repo files (#1951) Co-authored-by: Philip Top <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix updated google test issue Co-authored-by: Ryan Mast <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Philip Top <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
I made the #1710 change but can pull it out if needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think removing * @endforcpponly
(and maybe @forcpponly
) should remove the entire line rather than leaving a blank line; going through and doing that could be tedious, so maybe it could be done later with a pass through the rest of the doc strings.
Co-authored-by: Ryan Mast <[email protected]>
yeah, I noticed that, the regex replace in visual studio is a little annoying to deal with new lines, I will be going through all the doc strings as part of the next few weeks and cleaning up the warnings from doxygen so will clean it up as part of that process. |
Co-authored-by: Philip Top <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Summary
If merged this pull request will add helicsFederateDisconnect calls and remove the @forcpponly references that were a relic of the previous python doc attempt.