Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api tweaks #1952

Merged
merged 12 commits into from
Jun 10, 2021
Merged

Api tweaks #1952

merged 12 commits into from
Jun 10, 2021

Conversation

phlptp
Copy link
Member

@phlptp phlptp commented Jun 9, 2021

Summary

If merged this pull request will add helicsFederateDisconnect calls and remove the @forcpponly references that were a relic of the previous python doc attempt.

@phlptp phlptp requested a review from nightlark June 9, 2021 21:35
Co-authored-by: Philip Top <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@phlptp
Copy link
Member Author

phlptp commented Jun 10, 2021

I will add the change from #1710 to this if @kdheepak approves

phlptp and others added 6 commits June 9, 2021 17:32
* merge documentation changes and update support for cmake 3.20 and boost 1.76

* Update docs/user-guide/advanced_topics/webserver.md

Co-authored-by: Ryan Mast <[email protected]>

* Automated formatting of repo files (#1951)

Co-authored-by: Philip Top <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* fix updated google test issue

Co-authored-by: Ryan Mast <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Philip Top <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@phlptp
Copy link
Member Author

phlptp commented Jun 10, 2021

I made the #1710 change but can pull it out if needed.

@phlptp phlptp requested a review from kdheepak June 10, 2021 15:44
Copy link
Member

@nightlark nightlark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think removing * @endforcpponly (and maybe @forcpponly) should remove the entire line rather than leaving a blank line; going through and doing that could be tedious, so maybe it could be done later with a pass through the rest of the doc strings.

src/helics/shared_api_library/helicsCore.h Outdated Show resolved Hide resolved
src/helics/shared_api_library/helicsCore.h Outdated Show resolved Hide resolved
src/helics/shared_api_library/helicsCore.h Outdated Show resolved Hide resolved
src/helics/shared_api_library/helicsCore.h Outdated Show resolved Hide resolved
src/helics/shared_api_library/helicsCore.h Outdated Show resolved Hide resolved
src/helics/shared_api_library/helicsCore.h Outdated Show resolved Hide resolved
@phlptp
Copy link
Member Author

phlptp commented Jun 10, 2021

yeah, I noticed that, the regex replace in visual studio is a little annoying to deal with new lines, I will be going through all the doc strings as part of the next few weeks and cleaning up the warnings from doxygen so will clean it up as part of that process.

Co-authored-by: Philip Top <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@phlptp phlptp merged commit befabab into helics3 Jun 10, 2021
@phlptp phlptp deleted the api_tweaks branch June 10, 2021 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants