Class name update #1580
Merged
Class name update #1580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Philip Top <[email protected]> Co-authored-by: HELICS-bot <[email protected]>
kdheepak
approved these changes
Sep 19, 2020
|
@nightlark can you take a look? |
nightlark
approved these changes
Sep 20, 2020
trevorhardy
added a commit
that referenced
this pull request
Oct 1, 2020
… v3userguide * 'v3userguide' of https://github.com/GMLC-TDC/HELICS: (30 commits) Moving helics juggle merlin example to user-guide examples replacing erroneous files Moving the simple orchestration examples to examples directory Adding the simple merlin example files here no message reorg added link to examples page moving examples folder to user-guide moved docs/installation to docs/user-guide/installation, updated .gitignore Adding UQ_DAG back Revertng orchestration monte carlo use guide again Class name update (#1580) Command interface (#1569) no message no message organizing the userguide tree toc testing testing toc links to APIs for toc moving around top-level docs ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If merged this pull request will change the names of some of the classes to start to work towards the agreed upon Naming conventions.
Change
helicsFederateGetCoreObjecttohelicsFederateGetCore