Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleting unnecessary exception declarations & curly brackets, modifying javadocs #46

Merged
merged 13 commits into from
Sep 17, 2020
Merged

Deleting unnecessary exception declarations & curly brackets, modifying javadocs #46

merged 13 commits into from
Sep 17, 2020

Conversation

bonaparten
Copy link
Contributor

No description provided.

@bonaparten bonaparten requested a review from FabiKo117 September 3, 2020 12:06
@tyrasd tyrasd added this to the 1.2 milestone Sep 3, 2020
@bonaparten bonaparten force-pushed the cleaning-code branch 2 times, most recently from e605814 to 4465503 Compare September 5, 2020 16:35
@bonaparten bonaparten changed the title Deleting unnecessary exception declarations & curly brackets WIP: Deleting unnecessary exception declarations & curly brackets Sep 8, 2020
@bonaparten bonaparten dismissed FabiKo117’s stale review September 8, 2020 15:18

since unchecked exception there is no need to declare it

@bonaparten bonaparten changed the title WIP: Deleting unnecessary exception declarations & curly brackets Deleting unnecessary exception declarations & curly brackets Sep 14, 2020
@bonaparten bonaparten changed the title Deleting unnecessary exception declarations & curly brackets Deleting unnecessary exception declarations & curly brackets, modifying javadocs Sep 14, 2020
FabiKo117
FabiKo117 suggested changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@FabiKo117 FabiKo117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments to the respective code lines

src/main/java/org/heigit/ohsome/ohsomeapi/executor/ExecutionUtils.java Outdated Show resolved Hide resolved
src/main/java/org/heigit/ohsome/ohsomeapi/executor/UsersRequestExecutor.java Show resolved Hide resolved
src/main/java/org/heigit/ohsome/ohsomeapi/executor/UsersRequestExecutor.java Show resolved Hide resolved
src/main/java/org/heigit/ohsome/ohsomeapi/inputprocessing/InputProcessingUtils.java Outdated Show resolved Hide resolved
src/main/java/org/heigit/ohsome/ohsomeapi/inputprocessing/InputProcessor.java Outdated Show resolved Hide resolved
FabiKo117
FabiKo117 approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@FabiKo117 FabiKo117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good now 👍

@bonaparten bonaparten changed the title Deleting unnecessary exception declarations & curly brackets, modifying javadocs WIP: Deleting unnecessary exception declarations & curly brackets, modifying javadocs Sep 17, 2020
@bonaparten bonaparten changed the title WIP: Deleting unnecessary exception declarations & curly brackets, modifying javadocs Deleting unnecessary exception declarations & curly brackets, modifying javadocs Sep 17, 2020
@FabiKo117 FabiKo117 merged commit 56c9109 into master Sep 17, 2020
@FabiKo117 FabiKo117 deleted the cleaning-code branch September 17, 2020 15:16
@tyrasd tyrasd added the code quality Topics around code quality, e.g. refactoring, better naming of methods/classes label Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabiKo117 FabiKo117 FabiKo117 approved these changes

Assignees
No one assigned
Labels
code quality Topics around code quality, e.g. refactoring, better naming of methods/classes
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
3 participants
@bonaparten @FabiKo117 @tyrasd