-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
addition to fix #141 #145
addition to fix #141 #145
Conversation
@rtroilo do we still want to maybe add a unit test regarding this issue? The thing is, if it should be an integration test, like most of the others, we'd have to find that problem within the Heidelberg.oshdb dataset, as that's the one used in our test environment. |
that would be very very cool, indeed :) |
So, we're looking for elements which are unchanged in the time interval of the query which have an empty geometry, so that they trigger the NPE at |
c5f2889
to
417ae19
Compare
I tried for a bit, but could not find any quick way to reproduce the bug with elements in the test data set. 😒 maybe we can go ahead without a test for this specific bug? |
in addition to fix in pr #144
add the additional fix for issue #141
regarding the fix #141 Co-authored-by: Martin Raifer <[email protected]>
417ae19
to
0749945
Compare
Description
replace null with empty enum set
addition to fix in pr #144 (issue #141)
Checklist
I have commented my codeI have written javadoc (required for public methods)I have made corresponding changes to the documentationI have adjusted the examples in the check-ohsome-api script or created an issue in the corresponding repository. More Information here.