Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addition to fix #141 #145

Merged
merged 3 commits into from
Mar 18, 2021
Merged

addition to fix #141 #145

merged 3 commits into from
Mar 18, 2021

Conversation

FabiKo117
Copy link
Contributor

@FabiKo117 FabiKo117 commented Mar 5, 2021

Description

replace null with empty enum set
addition to fix in pr #144 (issue #141)

Checklist

@FabiKo117 FabiKo117 added waiting for review This pull request needs a code review and removed waiting for review This pull request needs a code review labels Mar 5, 2021
rtroilo
rtroilo previously approved these changes Mar 5, 2021
@FabiKo117
Copy link
Contributor Author

@rtroilo do we still want to maybe add a unit test regarding this issue? The thing is, if it should be an integration test, like most of the others, we'd have to find that problem within the Heidelberg.oshdb dataset, as that's the one used in our test environment.

@joker234
Copy link
Member

joker234 commented Mar 5, 2021

@rtroilo do we still want to maybe add a unit test regarding this issue? The thing is, if it should be an integration test, like most of the others, we'd have to find that problem within the Heidelberg.oshdb dataset, as that's the one used in our test environment.

that would be very very cool, indeed :)

CHANGELOG.md Outdated Show resolved Hide resolved
@tyrasd
Copy link
Member

tyrasd commented Mar 8, 2021

@rtroilo do we still want to maybe add a unit test regarding this issue? The thing is, if it should be an integration test, like most of the others, we'd have to find that problem within the Heidelberg.oshdb dataset, as that's the one used in our test environment.

that would be very very cool, indeed :)

So, we're looking for elements which are unchanged in the time interval of the query which have an empty geometry, so that they trigger the NPE at createOSMFeature(ExecutionUtils.java:387)? The first condition might be easy to trigger since we can control the time interval of the test query, but not sure about the second one. Do you know which element(s) triggered the bug when you first encountered it?

@tyrasd tyrasd added this to the 1.4 milestone Mar 11, 2021
@tyrasd tyrasd added the bug Something isn't working label Mar 11, 2021
@tyrasd tyrasd force-pushed the addition-to-fix-#141 branch from c5f2889 to 417ae19 Compare March 18, 2021 11:01
@tyrasd
Copy link
Member

tyrasd commented Mar 18, 2021

So, we're looking for elements which are unchanged in the time interval of the query which have an empty geometry, so that they trigger the NPE at createOSMFeature(ExecutionUtils.java:387)?

I tried for a bit, but could not find any quick way to reproduce the bug with elements in the test data set. 😒 maybe we can go ahead without a test for this specific bug?

tyrasd
tyrasd previously approved these changes Mar 18, 2021
FabiKo117 and others added 3 commits March 18, 2021 12:13
in addition to fix in pr #144
add the additional fix for issue #141
regarding the fix #141

Co-authored-by: Martin Raifer <[email protected]>
@FabiKo117 FabiKo117 merged commit 97637d6 into master Mar 18, 2021
@FabiKo117 FabiKo117 deleted the addition-to-fix-#141 branch March 18, 2021 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants