Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #141 #144

Merged
merged 5 commits into from
Mar 4, 2021
Merged

fix issue #141 #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0fd53d3
fix issue #141
rtroilo Mar 4, 2021
d196499
Update CHANGELOG.md
rtroilo Mar 4, 2021
46f2da2
Update ElementsRequestExecutor.java
rtroilo Mar 4, 2021
bd0be35
Update CHANGELOG.md
joker234 Mar 4, 2021
6618eb0
change order of import
rtroilo Mar 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ Changelog
* fix some invalid filters in the default swagger examples ([#111])
* fix returning invalid GeoJSON using empty coordinates for deletion contributions ([#129], [#131])
* fix using a proper boolean data type instead of a string for contributionType in response ([#135])
* fix NPE with createOSMFeature ([#141])

### Performance and Code Quality

Expand All @@ -29,6 +30,7 @@ Changelog
[#131]: https://github.com/GIScience/ohsome-api/issues/131
[#135]: https://github.com/GIScience/ohsome-api/pull/135
[#138]: https://github.com/GIScience/ohsome-api/issues/138
[#141]: https://github.com/GIScience/ohsome-api/issues/141


## 1.3.2
Expand Down
3 changes: 2 additions & 1 deletion src/main/lombok/org/heigit/ohsome/ohsomeapi/executor/ElementsRequestExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
import org.heigit.bigspatialdata.oshdb.osm.OSMType;
import org.heigit.bigspatialdata.oshdb.util.OSHDBTag;
import org.heigit.bigspatialdata.oshdb.util.OSHDBTimestamp;
import org.heigit.bigspatialdata.oshdb.util.celliterator.ContributionType;
import org.heigit.bigspatialdata.oshdb.util.geometry.Geo;
import org.heigit.bigspatialdata.oshdb.util.tagtranslator.TagTranslator;
import org.heigit.bigspatialdata.oshdb.util.time.TimestampFormatter;
Expand Down Expand Up @@ -125,7 +126,7 @@ public static void extract(RequestResource requestResource, ElementsGeometry ele
geom = snapshot.getGeometryUnclipped();
}
return exeUtils.createOSMFeature(snapshot.getEntity(), geom, properties, keysInt, includeTags,
includeOSMMetadata, false, elemGeom, null);
includeOSMMetadata, false, elemGeom, EnumSet.noneOf(ContributionType.class));
}).filter(Objects::nonNull);
Metadata metadata = null;
if (processingData.isShowMetadata()) {
Expand Down