Replace bunch of string concatenation with usage of StringBulder #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxime-poulain
commented
May 10, 2023
| @@ -254,11 +264,6 @@ public static AuthenticationBuilder AddOidcAuthentication(this IServiceCollectio | |||
| cookiesConfigureOptionsType = Type.GetType(settings.CookiesConfigureOptionsType, true); | |||
| } | |||
|
|
|||
| if (string.IsNullOrWhiteSpace(settings.ResponseType)) | |||
| { | |||
| throw new MissingFieldException("A ResponseType is mandatory to define the OpenId Connect protocol."); | |||
There was a problem hiding this comment.
Instead of throwining the exception at the end if the setting is missing
I have moved up the check so the error is added to the error list.
Change is that MissingFieldException would not e thrown anymore.
|
|
||
| if (string.IsNullOrWhiteSpace(settings.OpenIdConnectEventsType)) |
There was a problem hiding this comment.
Instead of throwining the exception at the end if the setting is missing
I have moved up the check so the error is added to the error list.
Change is that MissingFieldException would not e thrown anymore.
|
I see there are now conflicts, I'll fix them in few days. I think there were people complaining about the usage of a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit aims to prevent unnecessary string concatenation.
While the choice of using a
StringBuilderwas made, there are alternatives:List<string>that gets flattened withstring.Join: now this method uses vectorization which makes its performance close to theStringBuilderMessage(s)