feature: Add TracingHandler for correlationId propagation. #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated Arc4u.Diagnostics.csproj to include OpenTelemetry package for net8.0 (v1.9.0) and net9.0 (v1.10.0). Introduced TracingHandler class for HTTP request/response tracing using OpenTelemetry, including CorrelationIdActivityExtensions for managing correlation IDs. Add tracing, testing, and package updates Updated `Arc4u.Diagnostics.csproj` and `Arc4u.UnitTest.csproj` to include new package references for `OpenTelemetry.Extensions.Hosting`, `RichardSzalay.MockHttp`, and `Microsoft.AspNetCore.Mvc.Testing` for `net8.0` and `net9.0`. Added `InternalsVisibleTo` in `DefaultActivitySourceFactory.cs` for `Arc4u.UnitTest`. Refactored `CategorySerilogTests.cs` and `SerilogTests.cs` to use updated namespaces and constants. Added `TracingHandler.cs` for HTTP request tracing with `OpenTelemetry` and `Arc4uApplicationBuilder.cs` for extended `WebApplicationFactory` configuration. Added `TracingHandlerTests.cs` to verify tracing functionality.
Refactored TracingHandler to use IActivitySourceFactory and updated correlation ID handling. Moved CorrelationIdActityExtensions to its own file. Introduced CorrelationIdHttpHeaders for HTTP header key constants. Updated tests to use Moq and added new tests for correlation ID propagation.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced CorrelationIdHttpHeaders and CorrelationIdActityExtensions classes in Arc4u.Diagnostics.Telemetry namespace for managing correlation IDs. Implemented TracingHandler class to handle HTTP requests and responses, ensuring correlation IDs are propagated correctly. Added unit tests in TracingHandlerTests to verify the behavior of TracingHandler.