-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
135 examples #196
135 examples #196
Conversation
Preview (below schema reference table): https://rdl-standard.readthedocs.io/en/135-examples/reference/schema/#hazard |
@duncandewhurst Mat's done a new version of the Fathom hazard data example, can I delete the example.json that's currently in the examples/hazard/fathom folder and rename the new version to example.json? |
@duncandewhurst I ran manage.py but I get the warning
but I don't think that's causing the issue? |
Yep, that's right. If the new example results in a different set of CSV files, you'll also need to update
Ah, I forgot to mention that the example RDLS metadata in the JSON file needs to be wrapped in an outer
Looks like this is a bug in the version of |
@odscjen let me know once the example JSON and CSV files are ready and I'll have a think about how best to present them in the docs. |
@duncandewhurst I realised that we do need the new spreadsheet version to finish updating the remaining examples, particularly the exposure one. If you could generate that (I wasn't sure how to) I can update the examples if you don't have time. Ping me in Signal if you need me to do that and I'll get it done tomorrow. |
@matamadio @stufraser1 this PR is ready for your review. Jen doesn't work Wednesdays so, with an eye on the workshop on Thursday, once you've reviewed we can merge it, if you're happy with it. I don't think there'll be time to add any more examples before Thursday, but we can make further changes and add more examples in future PRs. Edit: Preview link for convenience: https://rdl-standard.readthedocs.io/en/135-examples/reference/schema/ |
Related issues
Description
This PR:
./manage.py
to generate transposed CSV files from JSON examples for presentation in the schema reference documentationhazard
,exposure
,vulnerability
andloss
to reduce the length of the example CSV file namesMerge checklist
./manage.py
pre-commitIf you added or removed a field:
collapse
option of the jsonschema directives for dataset, resource, hazard, exposure, vulnerability and loss onreference/schema.md
Having trouble?
See how to resolve check failures.