Rollout multiple updates from develop to main #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Parallelize test suite runner * Remove unnecessary mocha options * Add max number of jobs to prevent timeouts * Add separate coverage command to limit workers for ci runner
* Created initial BorrelSchema entities + seeder * Created borrel-schema controller, service, response and request, update borrel-schema entities * Created basic GET in controller * Rename borrel schema and its related entities to events * Add tests for getEvents function * Fix and test event update and create functions * Add getShifts and (soft) delete shift functions * Add test for create and update shift endpoints * Add event shift answer update function and tests * Add first endpoints for events to new controller * Add PATCH event endpoint * Add event shift endpoints & fix swagger docs * Add endpoints to change shift availability and assignment & add type * Add endpoint to sync event answers and function to send reminder emails * Register controllers and timed events in production * Revert package-lock.json * Add explicit reference to shifts in event entity * Fix test suite * Increase EventService & EventController test coverage * Add endpoint to get number of times users were selected for shifts * @Yoronex fix ur lint * Reduce number of workers to prevent timeouts on CI runner --------- Co-authored-by: Sjoerd <[email protected]> Co-authored-by: Job van de Ven <[email protected]> Co-authored-by: Samuel Oosterholt <[email protected]>
* Fix voucher users being required to accept ToS * Refactor and rename borrelkaart to voucher * Add attribute to user entity whether user can go into debt * Change that GEWIS members can go into debt by default * Add check when making transaction whether user can go into debt * Lint fix * Fix endpoint documentation
* Fix OpenAPI docs for some event-related endpoints * Changed UserRequest to UpdateUserRequest in user-controller.ts --------- Co-authored-by: Roy Kakkenberg <[email protected]> Co-authored-by: Samuel <[email protected]>
* Changed the swagger.ts to use the new express-jsdoc-swagger. Changing all the files will be a gigantic hassle, but running swagger:validate will show if the generated swagger is valid. It does not show if the swagger contains everything you expect it to. * Migrated: banner-response.ts base-response.ts pagination.ts root-controller.ts * Migrated: authentication-controller.ts authentication-response.ts all authentication requests user-response.ts * Migrated: authentication-secure-controller.ts * Migrated: all responses, balance-controller.ts and some entities * Migrated: all requests * Migrated: banner-controller.ts * Migrated: container-controller.ts * Migrated: debtor-controller.ts * Migrated: event-controller.ts * Migrated: event-shift-controller.ts * Migrated all controllers * Small remaining changes and mistakes * Rebased on dev * Added logging * Started working on fixing the test files / finding out whats going wrong. * TODO Fix code to use specification.component.schemas instead of specification.definitions * Fixed test cases and some of the spec errors that came up. * Small test to fix CI * Small test to fix CI * Update build.yml * Added swagger-cli as devtool * Continued CI/CD testsuite bug fixing. * Continued CI/CD testsuite bug fixing. * Cleaned swagger.ts and removed old dep. * Missed a dangling endpoint * Small changes to try and fix runner * Fixed the stupid mistake * Function signature changed. * Small fix in test model * Small fix in test model path * Small typo * Small error fix * Changed generateSpecification params to include file patterns. * Removed all entity swagger doc to only leave Responses * Undid all the changes to the entities swaggerdoc since these are unused. * Applied requested pull changes. * Applied requested pull changes.
|
Note: this shall be fast forward merged only |
…eprecated and abandoned.express-s
Yoronex
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Migration to
express-jsdoc-swagger#114: Migration to express-jsdoc-swaggerexpress-jsdoc-swaggerfor API documentation. Involved migrating controllers, responses, requests, and some entities. Included fixes for test cases, CI/CD bugs, and logging enhancements.Fix/user openapi docs #101: Fix/user openapi docs
UserRequesttoUpdateUserRequestinuser-controller.ts.Voucher auto ToS accept & restrict users who can go into debt #79: Voucher auto ToS accept & restrict users who can go into debt
Feature/Events & planning #48: Feature/Events & planning
Parallelize test suite runner #64: Parallelize test suite runner