Fix NonUniqueResultException when retrieving an organ based on its abbreviation #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This limits the selection of an organ based on its abbreviation to the latest record. Previously Doctrine's ORM would throw an `NonUniqueResultException` when two organs shared the same abbreviation. This was not taking into consideration. The query will now only select the organ with the most recent `foundationDate`.
kokx
reviewed
Feb 9, 2020
This makes the limiter opt-inable as suggested.
kokx
approved these changes
Feb 9, 2020
tomudding
added a commit
to tomudding/gewisweb
that referenced
this pull request
May 15, 2023
Note that this only fixes this when displaying a list of organs on the profile of a member. A similar problem was addressed in GEWISGH-982 but can never be completely fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #978.
Previously Doctrine's ORM would throw an
NonUniqueResultExceptionwhen two (or more) organs shared the same abbreviation. This limits the selection of an organ based on its abbreviation to the latest record. In other words, now the organ with the most recentfoundationDateis retrieved.