feat: improved cards for bodies, companies, and jobs #1934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Started out as a rewrite for the broken cards used to display BM and GMM bodies. I believe I broke their spacing many years ago when refactoring something else, but I never had the need to fix it (as people stopped complaining). The cards for companies always worked but looking back at the Sass code, they were just interfering with each other in which the body overview lost. Cards are now unified and follow the newer Boostrap styling more closely. --- Intention was to fix the styling for BM/GMM bodies where the abbreviation of the body was not visible due to the usage of picture with a white(-ish) background. This has been resolved by moving all text back into the body of the card instead of on top of the cover image. Sizing and grid layout are handled through CSS. If there is no cover image, the GEWIS logo is now shown (similar to how this is done in the Photo module).
|
This was supposed to be part of GH-1903; however, since that is taking longer than expected, I am moving this forward (note: these changes were never on that branch, only in my head up to a few hours ago). |
github-actions bot
added a commit
to tomudding/gewisweb
that referenced
this pull request
Dec 7, 2024
Tom Udding: Merge pull request GEWIS#1934 from tomudding/feature/improved-list-cards feat: improved cards for bodies, companies, and jobs Co-authored-by: tomudding <[email protected]>
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Started out as a rewrite for the broken cards used to display BM and GMM bodies. I believe I broke their spacing many years ago when refactoring something else, but I never had the need to fix it (as people stopped complaining).
The cards for companies always worked but looking back at the Sass code, they were just interfering with each other in which the body overview lost.
Cards are now unified and follow the newer Boostrap styling more closely.
Intention was to fix the styling for BM/GMM bodies where the abbreviation of the body was not visible due to the usage of picture with a white(-ish) background. This has been resolved by moving all text back into the body of the card instead of on top of the cover image. Sizing and grid layout are handled through CSS.
If there is no cover image, the GEWIS logo is now shown (similar to how this is done in the Photo module).
Before:
After:
Types of changes