Make membership type changes retroactive again #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This puts back the original idea of how manual membership type changes are computed. They are now retroactively applied. Any changes made will appear to have been like this since the end of the previous association year. For example, if a member is currently `graduate` on 2022-08-04 with a `membershipEndsOn` of 2022-07-1, changing them to `member` removes the `membershipEndsOn` and puts their `expiration` on 2023-07-01. Another example, if a member is currently `member` on 2022-08-04, changing them to `external` will put `membershipEndsOn` to 2022-07-01 and their `expiration` on 2023-07-01.
Koen1999
approved these changes
Aug 6, 2022
rinkp
reviewed
Aug 6, 2022
Yeah that is a good idea. Initially I thought about adding a year selector such that they can choose a year themselves, but this is a lot easier/simpler for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This puts back the original idea of how manual membership type changes are computed. They are now retroactively applied. Any changes made will appear to have been like this since the end of the previous association year.
For example, if a member is currently
graduateon 2022-08-04 with amembershipEndsOnof 2022-07-1, changing them tomemberremoves themembershipEndsOnand puts theirexpirationon 2023-07-01.Another example, if a member is currently
memberon 2022-08-04, changing them toexternalwill putmembershipEndsOnto 2022-07-01 and theirexpirationon 2023-07-01.Fixes #170.