Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cronjobs to prepare for deployment #191

Merged
merged 2 commits into from
Aug 9, 2022
Merged

Add cronjobs to prepare for deployment #191

merged 2 commits into from
Aug 9, 2022

Conversation

tomudding
Copy link
Member

Should do the same as is currently on the server, with the exception that it does not send any e-mails. Perhaps we should change the generation of report to full?

@tomudding tomudding self-assigned this Aug 4, 2022
@tomudding tomudding requested review from Koen1999 and rinkp August 4, 2022 17:47
Koen1999
Koen1999 approved these changes Aug 6, 2022
View reviewed changes
Copy link
Contributor

@Koen1999 Koen1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the change looks good, but I am not sure what the difference is between full and partial. So it's up to your discretion.

rinkp
rinkp approved these changes Aug 6, 2022
View reviewed changes
Copy link
Member

@rinkp rinkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the full report would be useful to run. We do have the compute resources for it easily and although the database frontend isn't supposed to violate the rules, it prevents additional manual changes later on (as we did on July 1st)

@tomudding
Switch to full reportdb generation
a17e38a 
To ensure that all data in reportdb is properly generated we have
to use the `full` variant. This also means that the organ
subdecision table is correctly updated.
@tomudding tomudding merged commit 602bc94 into GEWIS:master Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rinkp rinkp rinkp approved these changes

@Koen1999 Koen1999 Koen1999 approved these changes

Assignees

@tomudding tomudding

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomudding @rinkp @Koen1999