Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/fixes #3175 #3212

Merged
merged 9 commits into from
Dec 4, 2024
Merged

Feature/fixes #3175 #3212

merged 9 commits into from
Dec 4, 2024

Conversation

bena-nasa
Copy link
Collaborator

@bena-nasa bena-nasa commented Dec 3, 2024 •
edited
Loading

Fixes #3175
Address 2 issues.

  1. The pole should have no effect on the grid periodicity in the longitude direction
  2. If the file has CF compliant bounds for the coordinate we should use those to define the edges rather than the heuristics and so forth.

I have confirmed that this is zero-diff at least with the files we are using for ExtData now. This will allow Bin and Mike to use these files with bounds.

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

Related Issue

@bena-nasa bena-nasa added 🎁 New Feature This is a new feature 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. labels Dec 3, 2024
@bena-nasa bena-nasa requested a review from a team as a code owner December 3, 2024 17:31
@bena-nasa bena-nasa requested a review from tclune December 3, 2024 17:40
tclune
tclune approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a small change to simplify conditional logic for presence of bnds.

@mathomp4 mathomp4 merged commit 6f84fdb into develop Dec 4, 2024
37 checks passed
@mathomp4 mathomp4 deleted the feature/fixes-#3175 branch December 4, 2024 23:20
@mfmehari
Copy link

mfmehari commented Dec 6, 2024

@bena-nasa @tclune Great work! Thank you very much for fixing the bug!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tclune tclune tclune approved these changes

Assignees
No one assigned
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🎁 New Feature This is a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bena-nasa @mfmehari @tclune @mathomp4