Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/bmauer/fixes #3210 #3211

Merged
merged 4 commits into from
Dec 3, 2024
Merged

Feature/bmauer/fixes #3210 #3211

merged 4 commits into from
Dec 3, 2024

Conversation

bena-nasa
Copy link
Collaborator

Moved some code so now one can retrieve a string/real/int attribute from a Variable instance via helper functions in the Variable class. Used these to simplify the helper functions in FIleMetaDataUtilities.F90

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

Related Issue

@bena-nasa bena-nasa added 🎁 New Feature This is a new feature 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. labels Dec 3, 2024
@bena-nasa bena-nasa requested a review from a team as a code owner December 3, 2024 16:59
@bena-nasa bena-nasa requested a review from tclune December 3, 2024 17:37
tclune
tclune approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had no idea that these were not already implemented.

I strongly suspect we should be able to avoid the duplication, but not worth the trouble just now.

@mathomp4 mathomp4 merged commit 58ddb04 into develop Dec 3, 2024
37 checks passed
@mathomp4 mathomp4 deleted the feature/bmauer/fixes-#3210 branch December 3, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tclune tclune tclune approved these changes

Assignees
No one assigned
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🎁 New Feature This is a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bena-nasa @tclune @mathomp4