Feature/pchakrab/#12 create tp core driver #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sets the traceback flag based on the compiler chosen
pchakraborty
added
the
0 diff structural
tclune
approved these changes
Jan 15, 2020
There was a problem hiding this comment.
@pchakraborty I'm hesitant to add this onto the orphan development branch. There is a risk it will be lost when we adopt the GFDL branch. OTOH, there is a risk if we don't merge as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch, containing the tp_core driver does not involve Kokkos and can be safely merged to geos/develop. The
CMakeLists.txtis modified to include building the tp_core driver. Other than that, all changes are encapsulated in themodel/tpcore-driverdirectory.