v12: Convert Solar GC to use gFTL StringVector #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathomp4
added
the
0 diff
mathomp4
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests with
ifxfound it was segfaulting (for some reason) in this "array of strings" construct that was in the Solar GridComp.Even my cursory knowledge of gFTL thought "Hey, this looks like gFTL!". So with the help of @bena-nasa we have converted the code to use StringVector!
Initial tests seem to say it works...or at least doesn't crash. I need to do more tests on discover with ifort, gfortran, etc.
Note that this might not be the best gFTL code. Once @tclune is back, I'll have him give it a look-see.
ETA: Confirmed zero-diff with v12 and ifort 2021.13