Bypass MAPL_LoadBalance when not running load balancing, add maxpasses as resource #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the load balancing code in the Solar GridComp to avoid calls to
MAPL_LoadBalance
if not running with load balancing on.As found by @wmputman, if you set
SOLAR_LOAD_BALANCE: 0
you technically still call theMAPL_LoadBalance
code which involvesMPI_Allgather
,MPI_Send
andMPI_Recv
calls. Trivial though they are, at high-res they can be expensive.So, what we do here is make some changes to avoid this. Testing shows this change is zero-diff if you run with load balancing on.
Also added is code from @wmputman to pass in the max number of passes to the loadbalancer if running it. The default is 100 which is the baked default in
MAPL_LoadBalance.F90
Working with @dr0cloud, we have fixed the issue with the odd checkpoints. It is now fully zero-diff.
Working with @atrayano, we have fixed issues with the timers not being happy with no-solar processes going into RRTMG and not triggering the timeron/off.