Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new update type to jointly assimilate Tb, SM and SCF observations in single analysis #68

Merged
merged 26 commits into from
Dec 3, 2024

Conversation

amfox37
Copy link
Contributor

@amfox37 amfox37 commented Nov 19, 2024

Adding a new update_type=12 that allows for the joint assimilation of SMAP/SMOS Tb, ASCAT SM, and MODIS SCF.

A relatively simple merger of existing update_type=11 and update_type=13 which first determines what species of observations are assimilated per the namelist and then loops through the tiles looking for these obs and performing the snow and/or soil moisture analysis.

As commented in the code:

    ! Loop through tiles, first apply 1d snow update, then apply 3d soil moisture update.
    !
    ! 1d snow analysis: 
    !   Update each tile separately using all observations associated with the tile.
    !   Loop through ensemble members and compute analysis separately for each ensemble member.
    !
    ! 3d soil moisture/Tskin/ght(1) analysis: 
    !   Update each tile separately using all observations within customized halo around the tile.
    !   State vector of each tile depends on assimilated obs and soil type.
    !
    !   obs             | soil    | N_state | state vector
    !   ----------------------------------------------------------------------
    !   sfcm/sfds only  | mineral |     2   | srfexc, rzexc
    !   sfcm/sfds only  | peat    |     3   | srfexc, rzexc, catdef, 
    !   sfcm/sfds & Tb  | mineral |     6   | srfexc, rzexc,         tc[x], ght(1)
    !   sfcm/sfds & Tb  | peat    |     7   | srfexc, rzexc, catdef, tc[x], ght(1)

@amfox37 amfox37 added enhancement New feature or request 0-diff labels Nov 19, 2024
amfox37 and others added 6 commits November 18, 2024 18:07
…analysis:

- changed number associated with update_type 14 --> 12
- modified "check_snow" (maintains 0-diff for update_type=10 only!)
- simplified how species of interest are obtained
- added check of consistency between update_type and obs_param%assim
- additional clean-up (log messages, indentation)
@gmao-rreichle gmao-rreichle changed the title Add update type 14 to jointly assimilate Tb, SM and SCF observations in single analysis Add update type 12 to jointly assimilate Tb, SM and SCF observations in single analysis Nov 29, 2024
@gmao-rreichle gmao-rreichle changed the title Add update type 12 to jointly assimilate Tb, SM and SCF observations in single analysis Add new update type to jointly assimilate Tb, SM and SCF observations in single analysis Nov 29, 2024
@gmao-rreichle
Copy link
Collaborator

Successfully completed CONUS, GLOBAL, and GLOBALCS nightly tests after c4a1826

…n "select case" (clsm_ensupd_upd_routines.F90)
@gmao-rreichle gmao-rreichle marked this pull request as ready for review December 3, 2024 02:13
@gmao-rreichle gmao-rreichle requested a review from a team as a code owner December 3, 2024 02:13
@biljanaorescanin
Copy link
Collaborator

All tests passed.

@gmao-rreichle gmao-rreichle merged commit 930dc28 into develop Dec 3, 2024
11 checks passed
@gmao-rreichle gmao-rreichle deleted the feature/amfox/basic_SM_SNOW branch December 3, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-diff enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants