Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GOCART Data handling, update other setup scripts #454

Merged
merged 2 commits into from
May 10, 2023

Conversation

mathomp4
Copy link
Member

This PR does a couple things.

First, it "borrows" the >>>HIST_GOCART<<< bit to delete lines in AGCM.rc.tmpl that removes the MCHEMTRI stuff from @atrayano and @bena-nasa when running GOCART Data. If those are enabled, crashes appear!

Second, I tried to update the other setup scripts with the changes from @wmputman in re DT change. My hope is that it all works but is just out of tune? Not sure. But probably @mmanyin will need to make tweaks. Sorry about that.

@mathomp4 mathomp4 added bugfix This pull request fixes a bug 0 diff The changes in this pull request have verified to be zero-diff with the target branch. labels May 10, 2023
@mathomp4 mathomp4 self-assigned this May 10, 2023
@mathomp4 mathomp4 marked this pull request as ready for review May 10, 2023 15:36
@mathomp4 mathomp4 requested a review from a team as a code owner May 10, 2023 15:36
@sdrabenh sdrabenh merged commit b674159 into develop May 10, 2023
@sdrabenh sdrabenh deleted the feature/mathomp4/fix-gocartdata-agcm branch May 10, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch. bugfix This pull request fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants