Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn off 'doing_OCS' for gmichem simulations #433

Merged
merged 2 commits into from
Mar 24, 2023
Merged

Turn off 'doing_OCS' for gmichem simulations #433

merged 2 commits into from
Mar 24, 2023

Conversation

vlvalenti
Copy link

doing_OCS:yes requires that StratChem is being run with ACHEM and GOCART2G enabled, OCS mechanism not coupled to GMI currently

@vlvalenti vlvalenti added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Mar 24, 2023
@vlvalenti vlvalenti requested a review from a team as a code owner March 24, 2023 17:08
This was referenced Mar 24, 2023
Merged
Merged
@vlvalenti
Copy link
Author

This pull request depends on:
#2 in GMI
#254 in GEOSchem_GridComp
#218 in GOCART

@mathomp4 mathomp4 requested a review from mmanyin March 24, 2023 17:25
mmanyin
mmanyin reviewed Mar 24, 2023
View reviewed changes
Copy link
Contributor

@mmanyin mmanyin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an important fix -- please approve!
Note that this PR supports the PR's that @vlvalenti listed in GMI, CHEM and GOCART, but it does not require them; it can accepted independently of them, and is zero-diff for all cases.

@mathomp4
Copy link
Member

This is an important fix -- please approve! Note that this PR supports the PR's that @vlvalenti listed in GMI, CHEM and GOCART, but it does not require them; it can accepted independently of them, and is zero-diff for all cases.

@mmanyin So this does not need those other PRs (rather they need it?) If so, I have no reason not to accept this then. I mean, it's gmichem_setup which I don't even know how to run! 😄

@mathomp4 mathomp4 merged commit 73d8d90 into develop Mar 24, 2023
@vlvalenti vlvalenti deleted the feature/vvalenti/gocart2g_to_gmi_connectivity branch March 25, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmanyin mmanyin mmanyin left review comments

@mathomp4 mathomp4 mathomp4 approved these changes

Assignees
No one assigned
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vlvalenti @mathomp4 @mmanyin