Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HEARTBEAT_DT question #426

Merged
merged 4 commits into from
Mar 15, 2023
Merged

Add HEARTBEAT_DT question #426

merged 4 commits into from
Mar 15, 2023

Conversation

sdrabenh
Copy link
Collaborator

Add an additional input question to gcm_setup asking the user for the model HEARTBEAT_DT. Override with 450 for BACM_1M cases.

@sdrabenh
Add an additional input question to gcm_setup asking the user for the…
7279ed2 
… model HEARTBEAT_DT. Override with 450 for BACM_1M cases.
@sdrabenh sdrabenh added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Mar 14, 2023
@sdrabenh sdrabenh requested a review from mathomp4 March 14, 2023 14:53
@sdrabenh sdrabenh requested a review from a team as a code owner March 14, 2023 14:53
mathomp4
mathomp4 reviewed Mar 14, 2023
View reviewed changes
gcm_setup Show resolved Hide resolved
@mathomp4
Copy link
Member

mathomp4 commented Mar 14, 2023 •
edited
Loading

A question for @wmputman: should we make this "resolution dependent"? I mean, DT=450 is the default (currently) for C360. For lower resolutions it ranges from 600 (C180) to 1800 seconds (C12), and for higher resolutions the DT is lower.

ETA: Bill said, nope. so...okay! 😄

@mathomp4
Copy link
Member

I've updated the CI with my new create_expt.py script which should support the new heartbeat question. We'll see if the run works.

@mathomp4
Copy link
Member

Sigh. Found more bugs. Update incoming...

@mathomp4 mathomp4 self-requested a review March 15, 2023 16:22
@mathomp4 mathomp4 added Non 0-diff The changes in this pull request are non-zero-diff 0 diff The changes in this pull request have verified to be zero-diff with the target branch. and removed 0 diff The changes in this pull request have verified to be zero-diff with the target branch. labels Mar 15, 2023
mathomp4
mathomp4 approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@mathomp4 mathomp4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the CI is working now. So I'll approve. I also added the heartbeat chunk to the other setups.

@sdrabenh sdrabenh merged commit b6065bb into develop Mar 15, 2023
@sdrabenh sdrabenh deleted the feature/sdrabenh/add_HB_question_to_setup branch March 15, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathomp4 mathomp4 mathomp4 approved these changes

Assignees
No one assigned
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch. Non 0-diff The changes in this pull request are non-zero-diff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdrabenh @mathomp4