Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes added in GEOS to assimilate CrIS-FSR observations from NOAA-21 #169

Merged
merged 4 commits into from
Sep 24, 2024

Conversation

gmao-wgu
Copy link
Contributor

These resource files have been modified to include CrIS-FSR observations from NOAA-21.

@gmao-wgu gmao-wgu requested a review from a team as a code owner July 18, 2024 19:28
Copy link

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found:

@gmao-wgu gmao-wgu added the enhancement New feature or request label Jul 18, 2024
Copy link

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found: enhancement

@gmao-wgu gmao-wgu added the Non 0-diff The changes in this pull request are non-zero-diff label Jul 18, 2024
@@ -172,9 +172,9 @@ OBS_INPUT::
iasibufr iasi metop-c iasi_metop-c 0.0 3 0 ncep_mtiasi_bufr
atmsbufr atms npp atms_npp 0.0 1 0 ncep_atms_bufr
atmsbufr atms n20 atms_n20 0.0 1 0 ncep_atms_bufr
atmsbufr atms n21 atms_n21 0.0 1 0 ncep_atms_bufr
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete the atms_n21 line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess my base line does not have that atms_n21 line. I will add that line back.

@gmao-wgu gmao-wgu requested a review from gmao-msienkie July 29, 2024 19:51
gmao-jjin3
gmao-jjin3 previously approved these changes Jul 30, 2024
Copy link
Contributor

@rtodling rtodling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good to me. Please notice I move the changes to the sat-db to

GEOS-ESM/GEOS_mksi#4

@rtodling rtodling merged commit 1a5f406 into develop Sep 24, 2024
2 checks passed
Copy link
Contributor

@rtodling rtodling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where the changes for NPP meant here?!

@gmao-wgu
Copy link
Contributor Author

Ricardo, could you please be more specific here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Non 0-diff The changes in this pull request are non-zero-diff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants