-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposed R21C changes 2024-01-29 #156
Conversation
Can you provide a written list of all changes made here, please? Amal is probably the person to do this. Thanks |
Here's a list of all the changes: Let me know if you questions about any of theses. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I can tell, these changes seem good.
I will take the word here that when ta2tb = false the code does give zero diff - as indicated in the label.
Can you provide here the version number of GEOSana_GridComp this started from? |
I started from v1.5.5 GEOSana_GridComp | (t) v1.5.5 (DH) | (b) feature/aelakkra/r21c_DAScandidate |
Amal and Scott - it seems to me this is still in Draft mode - I can't finish this until the PR is officially submitted |
You are right. They should've been submitted as official PRs. I'll check with Scott immediately. |
@rtodling @elakkraoui these PR were initially marked as drafts for reviewing. Clicking the button "Ready for review" now so they are regular PRs. Please keep in mind CircleCI may fail for some of these PRs as we don't have an automated way to checkout latest within the R21C branches just yet. |
Labeled as zero-diff from the GCM perspective. Updates originally from @elakkraoui