Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed R21C changes 2024-01-29 #156

Merged
merged 3 commits into from
Feb 29, 2024
Merged

Conversation

sdrabenh
Copy link

@sdrabenh sdrabenh commented Jan 31, 2024

Labeled as zero-diff from the GCM perspective. Updates originally from @elakkraoui

@sdrabenh sdrabenh added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Jan 31, 2024
@sdrabenh sdrabenh requested review from a team as code owners January 31, 2024 15:33
@sdrabenh sdrabenh marked this pull request as draft January 31, 2024 16:55
@rtodling
Copy link
Contributor

rtodling commented Feb 1, 2024

Can you provide a written list of all changes made here, please? Amal is probably the person to do this. Thanks

@elakkraoui
Copy link
Contributor

Can you provide a written list of all changes made here, please? Amal is probably the person to do this. Thanks

Here's a list of all the changes:
List_updates_4_M21C_CandidateTag.docx

Let me know if you questions about any of theses. Thanks.

Copy link
Contributor

@rtodling rtodling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can tell, these changes seem good.

I will take the word here that when ta2tb = false the code does give zero diff - as indicated in the label.

@rtodling
Copy link
Contributor

Can you provide here the version number of GEOSana_GridComp this started from?

@elakkraoui
Copy link
Contributor

Can you provide here the version number of GEOSana_GridComp this started from?

I started from v1.5.5

GEOSana_GridComp | (t) v1.5.5 (DH) | (b) feature/aelakkra/r21c_DAScandidate

@rtodling
Copy link
Contributor

Amal and Scott - it seems to me this is still in Draft mode - I can't finish this until the PR is officially submitted

@elakkraoui
Copy link
Contributor

Amal and Scott - it seems to me this is still in Draft mode - I can't finish this until the PR is officially submitted

You are right. They should've been submitted as official PRs. I'll check with Scott immediately.

@sdrabenh sdrabenh marked this pull request as ready for review February 26, 2024 13:52
@sdrabenh
Copy link
Author

@rtodling @elakkraoui these PR were initially marked as drafts for reviewing. Clicking the button "Ready for review" now so they are regular PRs. Please keep in mind CircleCI may fail for some of these PRs as we don't have an automated way to checkout latest within the R21C branches just yet.

@mathomp4 mathomp4 merged commit 122082b into R21C Feb 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants