Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/jjin3/atms n21 #153

Merged
merged 3 commits into from
Mar 1, 2024
Merged

Feature/jjin3/atms n21 #153

merged 3 commits into from
Mar 1, 2024

Conversation

gmao-jjin3
Copy link
Contributor

Add a new type of microwave radiance observation: ATMS NOAA21. Its observational errors and quality control procedures are set as same as those for ATMS NOAA20. However, bias correction coefficients are tuned by a standalone run with f5295_fp with the whole observational data set and ATMS NOAA21 data in July 2023. These coefficients are stored on discover:
/discover/nobackup/projects/gmao/obsdev/jjin3/x49atms/run/atms_n21_bc/x49atms.ana_satbiaspc_rst.20230714_21z.txt
/discover/nobackup/projects/gmao/obsdev/jjin3/x49atms/run/atms_n21_bc/x49atms.ana_satbias_rst.20230714_21z.txt

@gmao-jjin3 gmao-jjin3 requested a review from a team as a code owner November 8, 2023 04:07
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2023

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found:

@gmao-jjin3 gmao-jjin3 added enhancement New feature or request Non 0-diff The changes in this pull request are non-zero-diff observation configuration Change to configuration of obs input labels Nov 8, 2023
@gmao-jjin3 gmao-jjin3 self-assigned this Nov 8, 2023
@gmao-jjin3

This comment was marked as outdated.

Sign in to view
@gmao-yzhu
Copy link
Contributor

In satbiaspc file, I would suggest to replace all zeros of data counts to 150. This will avoid all treatments due to zero data counts at the first cycle.

@gmao-jjin3
Copy link
Contributor Author

@gmao-yzhu Thanks. Here is an updated part in the satbiaspc file:

 4016 atms_n21                 1  1.5000000E+02
      0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05
      0.1000000E+05  0.1000000E+05
 4017 atms_n21                 2  1.5000000E+02
      0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05
      0.1000000E+05  0.1000000E+05
 4018 atms_n21                 3  1.5000000E+02
      0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05
      0.1000000E+05  0.1000000E+05
 4019 atms_n21                 4  1.5000000E+02
      0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05
      0.1000000E+05  0.1000000E+05
 4020 atms_n21                 5  1.5000000E+02
      0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05
      0.1000000E+05  0.1000000E+05
 4021 atms_n21                 6  1.5000000E+02
      0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05
      0.1000000E+05  0.1000000E+05
 4022 atms_n21                 7  1.5000000E+02
      0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05
      0.1000000E+05  0.1000000E+05
 4023 atms_n21                 8  1.5000000E+02
      0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05
      0.1000000E+05  0.1000000E+05
 4024 atms_n21                 9  1.5000000E+02
      0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05
      0.1000000E+05  0.1000000E+05
 4025 atms_n21                10  1.5000000E+02
      0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05
      0.1000000E+05  0.1000000E+05
 4026 atms_n21                11  1.5000000E+02
      0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05
      0.1000000E+05  0.1000000E+05
 4027 atms_n21                12  1.5000000E+02
      0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05
      0.1000000E+05  0.1000000E+05
 4028 atms_n21                13  1.5000000E+02
      0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05
      0.1000000E+05  0.1000000E+05
 4029 atms_n21                14  1.5000000E+02
      0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05
      0.1000000E+05  0.1000000E+05
 4030 atms_n21                15  1.5000000E+02
      0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05
      0.1000000E+05  0.1000000E+05
 4031 atms_n21                16  1.5000000E+02
      0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05
      0.1000000E+05  0.1000000E+05
 4032 atms_n21                17  1.5000000E+02
      0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05
      0.1000000E+05  0.1000000E+05
 4033 atms_n21                18  1.5000000E+02
      0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05
      0.1000000E+05  0.1000000E+05
 4034 atms_n21                19  1.5000000E+02
      0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05
      0.1000000E+05  0.1000000E+05
 4035 atms_n21                20  1.5000000E+02
      0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05
      0.1000000E+05  0.1000000E+05
 4036 atms_n21                21  1.5000000E+02
      0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05
      0.1000000E+05  0.1000000E+05
 4037 atms_n21                22  1.5000000E+02
      0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05  0.1000000E+05
      0.1000000E+05  0.1000000E+05

@gmao-jjin3
Copy link
Contributor Author

I think these new bias correction coefficient are good to be added in the file satbias.txt:

 4016 atms_n21                 1   0.527909E+00   0.423426E+07   999
       -0.401911    0.000000   65.740291    5.478985    1.913973    0.000000    0.000000    0.012554  -39.007273   -1.145161
      -12.121239    0.328237
 4017 atms_n21                 2   0.306324E+00   0.424773E+07   999
       -0.614049    0.000000  100.268756    8.872828    3.661302    0.000000    0.000000    0.012024  -65.642540   -0.532081
       -6.618570    0.144692
 4018 atms_n21                 3   0.195078E+01   0.508867E+07   999
       -0.309881    0.000000   56.410096   -2.618153   -0.751593    0.000000    0.000000    0.002166   16.262008    0.582675
       11.080571    0.162774
 4019 atms_n21                 4   0.288883E+01   0.590847E+07   999
       -1.053736    0.000000   31.583919   -0.370910   -0.006039    0.000000    0.000000    0.006162    1.724965    0.225114
        7.296563    0.095759
 4020 atms_n21                 5   0.444513E+01   0.649529E+07   999
       -0.723524    0.000000    8.785349    0.007973    0.042942    0.000000    0.000000    0.006361   -2.223134   -0.209017
        2.378256    0.070533
 4021 atms_n21                 6   0.600855E+01   0.651371E+07   999
       -0.460057    0.000000    0.652270    0.006941   -0.020462    0.000000    0.000000    0.002040   -0.153738   -0.299803
       -0.232636    0.033488
 4022 atms_n21                 7   0.727069E+01   0.117768E+08   999
       -0.293587    0.000000   -0.143188    0.000363    0.014935    0.000000    0.000000    0.002961    0.239578   -0.254102
       -0.514579    0.006562
 4023 atms_n21                 8   0.587887E+01   0.135488E+08   999
       -0.751496    0.000000   -0.050897   -0.001096   -0.018557    0.000000    0.000000    0.031474    0.237055   -0.255596
       -0.374622    0.021712
 4024 atms_n21                 9   0.412383E+01   0.136356E+08   999
       -0.733379    0.000000    0.006645   -0.001632   -0.039303    0.000000    0.000000    0.066040    0.140693   -0.160120
       -0.365375   -0.006293
 4025 atms_n21                10  -0.762593E+00   0.146518E+08   999
       -0.344603    0.000000   -0.110125    0.003842   -0.078547    0.000000    0.000000   -3.302785    0.170984   -0.107942
       -0.439898   -0.027132
 4026 atms_n21                11  -0.253401E+01   0.147677E+08   999
       -0.238614    0.000000   -0.075817    0.005620   -0.067846    0.000000    0.000000   -7.131829    0.207844   -0.106298
       -0.409061   -0.020390
 4027 atms_n21                12  -0.369294E+01   0.148689E+08   999
        0.079941    0.000000   -0.033169    0.008424   -0.160113    0.000000    0.000000   -2.242194    0.180370   -0.121939
       -0.428961   -0.008650
 4028 atms_n21                13  -0.509167E+01   0.144791E+08   999
       -0.214724    0.000000   -0.029015    0.002643   -0.080470    0.000000    0.000000   -0.008292    0.052751   -0.116422
       -0.355046   -0.006370
 4029 atms_n21                14  -0.615262E+01   0.145678E+08   999
       -0.005010    0.000000   -0.001791    0.001845   -0.072508    0.000000    0.000000    4.912558    0.129033   -0.151816
       -0.278692   -0.007698
 4030 atms_n21                15  -0.425791E+01   0.464924E+07   999
        0.259732    0.000000   -0.022856    0.008808   -0.015815    0.000000    0.000000    0.000000    0.418419   -0.143422
       -0.360799   -0.034853
 4031 atms_n21                16   0.916124E+00   0.340707E+07   999
       -1.595269    0.000000  125.118676    1.813353    1.165252    0.000000    0.000000    0.008299  -21.272231   -0.652487
       -1.892191    0.035252
 4032 atms_n21                17   0.229602E+01   0.454674E+07   999
       -0.417825    0.000000    5.666847    0.268898   -0.757315    0.000000    0.000000   -0.006503   -2.766785   -0.223207
        1.566672   -0.067534
 4033 atms_n21                18   0.383794E+01   0.543492E+07   999
       -0.252357    0.000000   -5.344865    0.022170   -0.070440    0.000000    0.000000   -0.008424    0.088117   -0.040774
       -0.879315   -0.110631
 4034 atms_n21                19   0.504737E+01   0.538058E+07   999
       -0.203302    0.000000   -5.474052    0.006255   -0.027680    0.000000    0.000000   -0.011520    1.090787    0.127933
       -1.228600   -0.157906
 4035 atms_n21                20   0.631568E+01   0.512232E+07   999
       -0.125725    0.000000   -5.495713    0.004383   -0.006818    0.000000    0.000000   -0.002753    1.158862    0.086219
       -1.077816   -0.121583
 4036 atms_n21                21   0.802823E+01   0.489174E+07   999
        0.091288    0.000000   -5.387889    0.001441    0.027487    0.000000    0.000000   -0.005124    0.472620    0.142716
       -0.582316   -0.136437
 4037 atms_n21                22   0.955803E+01   0.466305E+07   999
        0.158396    0.000000   -4.269220   -0.003503    0.047903    0.000000    0.000000   -0.056082    0.061733    0.062091
       -0.315268   -0.096178

@gmao-jjin3
Copy link
Contributor Author

Here are O-F of atms_n20 and atms_n21 in a standalone run using x0049 results and those new CRTM coefficient file for atms_n21:
omf_atms_n21_passive.x0049.pdf
These figures show AMTS_n21 O-F values are generally comparable to or smaller than those departures for ATMS_n21. Mean O-F values are very close to zero after bias correction.
@rtodling Can you copy those CRTM coefficient files into the default CRTM coefficient directory? They are in @gmao-wgu 's directory /discover/nobackup/projects/gmao/obsdev/wgu/crtm_REL-2.4.0_emc/fix_emc20221018_2.4.0/CRTM_Coeffs/Little_Endian/
atms_n21.SpcCoeff.bin
atms_n21-srf.SpcCoeff.bin
atms_n21-srf.TauCoeff.bin
atms_n21.TauCoeff.bin

You may want to copy over "cris-fsr_n21.SpcCoeff.binzz" and "cris-fsr_n21.TauCoeff.bin" as well. But, I defer that to you and @gmao-wgu. I gave Ben Johnson our current CRTM version number, but I didn't get a reply after that. I assume he will add these files in CRTM 2.4.0 and newer versions.

@gmao-jjin3
Copy link
Contributor Author

Forecast score verified by self-analysis in Aug 2023. The forecast is made with new ATMS_NOAA21 observations.
scorecard_x49atms_b_x0049_20230801_20230831

@gmao-jjin3
Copy link
Contributor Author

Forecast score verified by ERA-5 reanalysis in Aug 2023. The forecast is made with new ATMS_NOAA21 observations.

scorecard_x49atms_bXE5_x0049XE5_20230801_20230831

rtodling
rtodling approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@rtodling rtodling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good to me.

@rtodling rtodling merged commit e3678da into develop Mar 1, 2024
This was referenced Mar 1, 2024
Merged
Merged
@gmao-jjin3
Copy link
Contributor Author

@rtodling I just want to let you know that I did not add "atms_n21" in the ensemble in these two file in my PR:

GEOSadas/src/Applications/NCEP_Etc/NCEP_enkf/scripts/gmao/etc/obs1gsi_mean.rc
GEOSadas/src/Applications/NCEP_Etc/NCEP_enkf/scripts/gmao/etc/obs1gsi_member.rc

@rtodling
Copy link
Contributor

rtodling commented Mar 1, 2024

@rtodling I just want to let you know that I did not add "atms_n21" in the ensemble in these two file in my PR:

GEOSadas/src/Applications/NCEP_Etc/NCEP_enkf/scripts/gmao/etc/obs1gsi_mean.rc GEOSadas/src/Applications/NCEP_Etc/NCEP_enkf/scripts/gmao/etc/obs1gsi_member.rc

Yes - that's another place that needs attention. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtodling rtodling rtodling approved these changes

@gmao-yzhu gmao-yzhu Awaiting requested review from gmao-yzhu

Assignees

@gmao-jjin3 gmao-jjin3

Labels
enhancement New feature or request Non 0-diff The changes in this pull request are non-zero-diff observation configuration Change to configuration of obs input
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gmao-jjin3 @gmao-yzhu @rtodling