fcst and das (run) should use the same land setup #127
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
somehow this does not show as a problem in most cases! For example, x0046a (and prePP) and x0045a - and other runs, the forecast reproduces the DAS during the period over IAU (as it should). The explanation for what is going on is provided by Rolf - quote here from email exchange:
if (LSM_CHOICE.eq.1) then
call MAPL_GetResource (SCF, LAND_PARAMS, label='LAND_PARAMS:', DEFAULT="NRv7.2", RC )
And LAND_PARAMS is also set to "NRv7.2" if the corresponding line in the Surface rc file is simply uncommented without making other changes.
In a nutshell, the model defines defaults in two places, the rc file and the MAPL_GetResource() calls. In recent tags, the respective defaults are consistent (which isn't true if you go back a year or so). Specifying the default settings in the rc file only makes the defaults show up conveniently in the log file, but nothing else changes unless you specify non-default values in the rc file.
Also: this is being labeled here as zero-diff since it is (incidentally) so for the choices land in the x-exps and FP/FPP/prePP runs. It is not the case for forecasts using the Icarus land -but I don't believe anyone is truly using this option anymore.