-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mesh_doctor installation via pip #18
base: main
Are you sure you want to change the base?
Conversation
I suspect that something will have to be fixed for the testing to work. |
never mind. Looks like we are not running pytest anyways. I just need to format the files. |
Shouldn’t #13 come first ? |
Rather than come first, I assume that #13 already solves the issue? If that's the case, we can also discard this PR. It really depends on what the timeline is. Coz, currently, the installation does not work which was annoying for me coz I needed to use it. If the other PR fixes it and it will be merged quickly we can discard this PR once that one is merged. If there is still work to do I would prefer merging this patch to fix the issue quickly. |
the changes in this PR are minimal. All I did was just adding an init file and fixing the steup.cfg. The toml file should address the issue of having the package well defined. I can simply try to go in your PR and see if the installtion works and fix it if doesn't. this way you won't have to deal with annoying conflicts due to name changes. |
Hello guys, it looks to me that #13 handles all the deployments issues of all our python tools at once and that it has been waiting for some time. |
We still need to iron out some issues with #13 in the main GEOS repo, and I hope to be able to look at it next week. If that works, then it could certainly take priority. |
I noticed that the installation of mesh_doctor was not working.
This PR allows to install mesh_doctor like all other geos python packages.