QML plugin #216
Merged
QML plugin #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 22, 2020 10:17
Allow to create components on the fly with QML
sebastian-wieczorek
force-pushed
the
sewi
branch
12 times, most recently
from
4f0b11b to
41779a2
Compare
Codecov Report
@@ Coverage Diff @@
## master #216 +/- ##
========================================
Coverage 99.80% 99.81%
========================================
Files 100 107 +7
Lines 3074 3240 +166
========================================
+ Hits 3068 3234 +166
Misses 6 6
Continue to review full report at Codecov.
|
sebastian-wieczorek
force-pushed
the
sewi
branch
5 times, most recently
from
799b025 to
11fbc2b
Compare
sebastian-wieczorek
force-pushed
the
sewi
branch
from
11fbc2b to
ad755e1
Compare
- Add dock/undock - Add show/hide log window - Change buttons layout Signed-off-by: Remigiusz Kołłątaj <[email protected]>
Signed-off-by: Remigiusz Kołłątaj <[email protected]>
Signed-off-by: Remigiusz Kołłątaj <[email protected]>
Signed-off-by: Remigiusz Kołłątaj <[email protected]>
Signed-off-by: Remigiusz Kołłątaj <[email protected]>
| @@ -96,27 +97,36 @@ public slots: | |||
| { | |||
| if(url.isValid() && !url.isEmpty()) | |||
| { | |||
| _qmlUrl = url; | |||
| // The easiest way to reload QML seems to be creating new QQuickWidget | |||
There was a problem hiding this comment.
loadQML function is aware of that so no fuss is needed here
There was a problem hiding this comment.
Not an expert here but I was getting a lot of warnings about NULL reference when reloading QML (although new QML was working properly...). It seems to me that clearComponentCache that was used to clear engine was not clearing context properties.
Signed-off-by: Remigiusz Kołłątaj <[email protected]>
Signed-off-by: Remigiusz Kołłątaj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to create QML plugins from external QML files.