Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

env : 에러 로그 웹훅 수정 #312

Merged
merged 1 commit into from
Jan 28, 2025
Merged

env : 에러 로그 웹훅 수정 #312

merged 1 commit into from
Jan 28, 2025

Conversation

hwangjokim
Copy link
Contributor

📌 Related Issue

close #311

🚀 Description

  • 디스코드에 에러 발생시 알림이 날아옵니다. Exception 발생시엔 괜찮았는데, log.error는 정상 작동하지 않았어요.
    AS - IS
스크린샷 2025-01-25 오후 11 51 36

TO - BE
image

📢 Review Point

  • Throwable 객체가 담겨있을때는 Exception, 아닌 경우엔 log.error입니다. 이 점을 인지하고 보시면 편할 것 같아요.

📚Etc (선택)

@hwangjokim hwangjokim added the trivial 로직과 관계없는 사소한 것들 label Jan 25, 2025
@hwangjokim hwangjokim self-assigned this Jan 25, 2025
@github-actions GitHub Actions
Copy link

Test Results

 18 files   18 suites   5s ⏱️
283 tests 283 ✅ 0 💤 0 ❌
285 runs  285 ✅ 0 💤 0 ❌

Results for commit e203912.

s-hwan
s-hwan approved these changes Jan 26, 2025
View reviewed changes
Copy link
Contributor

@s-hwan s-hwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

잘봤습니다!!👍

rladmstn
rladmstn approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@rladmstn rladmstn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@rladmstn rladmstn merged commit 87e83ae into develop Jan 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rladmstn rladmstn rladmstn approved these changes

@s-hwan s-hwan s-hwan approved these changes

@sh0723 sh0723 Awaiting requested review from sh0723

Assignees

@hwangjokim hwangjokim

Labels
trivial 로직과 관계없는 사소한 것들
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

로그 웹훅 수정
3 participants
@hwangjokim @s-hwan @rladmstn