Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor : 닉네임 검증 시 한글 제한 추가 #301

Merged
merged 2 commits into from
Jan 20, 2025
Merged

refactor : 닉네임 검증 시 한글 제한 추가 #301

merged 2 commits into from
Jan 20, 2025

Conversation

rladmstn
Copy link
Contributor

📌 Related Issue

close #300

🚀 Description

  • 기존에 영문, 한글, 숫자 포함한 3~16글자의 닉네임 조건에서 한글을 뺐습니다.

📢 Review Point

📚Etc (선택)

@rladmstn rladmstn added the refactoring 리팩토링 label Jan 18, 2025
@rladmstn rladmstn self-assigned this Jan 18, 2025
@github-actions GitHub Actions
Copy link

Test Results

 18 files   18 suites   5s ⏱️
283 tests 283 ✅ 0 💤 0 ❌
285 runs  285 ✅ 0 💤 0 ❌

Results for commit 6b3ab9a.

hwangjokim
hwangjokim approved these changes Jan 19, 2025
View reviewed changes
Copy link
Contributor

@hwangjokim hwangjokim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg

s-hwan
s-hwan approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@s-hwan s-hwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍

@rladmstn
Copy link
Contributor Author

박상혁씨 못볼 것 같으니 머지하겠습니다

@rladmstn rladmstn merged commit ebb8b6d into develop Jan 20, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwangjokim hwangjokim hwangjokim approved these changes

@s-hwan s-hwan s-hwan approved these changes

@sh0723 sh0723 Awaiting requested review from sh0723

Assignees

@rladmstn rladmstn

Labels
refactoring 리팩토링
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor : 닉네임 검증 시, 한글 제한 추가
3 participants
@rladmstn @s-hwan @hwangjokim