Hotfix: Correct the order of the parameters for the FPCA in Mahalanobis #506
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constructor for
FPCA
receives parameters in a different order than the one used inMahalanobis
.scikit-fda/skfda/preprocessing/dim_reduction/_fpca.py
Lines 87 to 94 in 05a35df
Thus, the last two parameters should be interchanged in the call to the constructor in
Mahalanobis
.