Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make weights parameter private #483

Merged
merged 5 commits into from
Oct 13, 2022
Merged

Conversation

Ddelval
Copy link
Contributor

@Ddelval Ddelval commented Oct 12, 2022

Choosing the weights for the numerical quadrature used during the calculation of FPCA does not seem like a parameter that the end user should need to tweak. Therefore, it has been removed from the documentation, and its name in the constructor has been prepended with an underscore to indicate that it is a private parameter now

@Ddelval Ddelval marked this pull request as draft October 12, 2022 11:52
@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Base: 85.28% // Head: 85.28% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (6215705) compared to base (099560f).
Patch coverage: 75.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #483      +/-   ##
===========================================
- Coverage    85.28%   85.28%   -0.01%     
===========================================
  Files          137      137              
  Lines        11043    11040       -3     
===========================================
- Hits          9418     9415       -3     
  Misses        1625     1625              
Impacted Files Coverage Δ
skfda/preprocessing/dim_reduction/_fpca.py 90.98% <66.66%> (-0.22%) ⬇️
skfda/tests/test_fpca.py 99.30% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Ddelval Ddelval marked this pull request as ready for review October 12, 2022 12:07
@vnmabus vnmabus merged commit e22beeb into develop Oct 13, 2022
@vnmabus vnmabus deleted the feature/private_weights_fpca branch August 17, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants