LLR for non orthonormal basis #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
tests/test_kernel_regression.py
Outdated
| class TestNonOthonormalBasisLLR(unittest.TestCase): | ||
| """Test LocalLinearRegression method with non orthonormal basis.""" | ||
|
|
||
| def test_llr_non_orthonormal(self): |
There was a problem hiding this comment.
🚫 [mypy] reported by reviewdog 🐶
Function is missing a return type annotation
tests/test_kernel_regression.py
Outdated
| class TestNonOthonormalBasisLLR(unittest.TestCase): | ||
| """Test LocalLinearRegression method with non orthonormal basis.""" | ||
|
|
||
| def test_llr_non_orthonormal(self): |
There was a problem hiding this comment.
📝 [mypy] reported by reviewdog 🐶
Use "-> None" if function does not return a value
Codecov Report
@@ Coverage Diff @@
## develop #430 +/- ##
========================================
Coverage 80.18% 80.19%
========================================
Files 93 93
Lines 7264 7266 +2
========================================
+ Hits 5825 5827 +2
Misses 1439 1439
Continue to review full report at Codecov.
|
vnmabus
requested changes
Mar 9, 2022
skfda/misc/hat_matrix.py
Outdated
|
|
||
| # Adding a column of ones in the first position of all matrices | ||
| dims = (C.shape[0], C.shape[1], 1) | ||
| C = np.c_[np.ones(dims), C] |
skfda/misc/hat_matrix.py
Outdated
|
|
||
| # Calculate new coefficients taking into account cross-products | ||
| # if the basis is orthonormal, C would not change | ||
| C = np.einsum( |
There was a problem hiding this comment.
Isn't this the same as C @= inner_product_matrix?
vnmabus
approved these changes
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #421