Remove alpha parameter of Magnitude-Shape plot and outlier detector. #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This alpha parameter was only used in the asymptotic case, when the number of samples was too high. - Add instead a cutoff_factor parameter that multiplies the cutoff and can be used for an arbitrary number of samples, to consider more or less functions as outliers.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -445,7 +443,7 @@ def _parameters_asymptotic( | |||
| # Calculation of the cutoff value and scaling factor to identify | |||
| # outliers. | |||
| scaling = estimated_c * dfd / estimated_m / dfn | |||
| cutoff_value = scipy.stats.f.ppf(self.alpha, dfn, dfd, loc=0, scale=1) | |||
| cutoff_value = scipy.stats.f.ppf(0.993, dfn, dfd, loc=0, scale=1) | |||
There was a problem hiding this comment.
[pep8] reported by reviewdog 🐶
WPS432 Found magic number: 0.993
Codecov Report
@@ Coverage Diff @@
## develop #424 +/- ##
========================================
Coverage 80.24% 80.24%
========================================
Files 92 92
Lines 7229 7229
========================================
Hits 5801 5801
Misses 1428 1428
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
number of samples was too high.
can be used for an arbitrary number of samples, to consider more or less
functions as outliers.